[PR #1252] [MERGED] [Feature] #1241 Do not automatically DOWNLOAD updates in metered networks #1338

New issue

Closed

opened 2026-02-26 09:34:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/1252
Author: @GopherTheCoder
Created: 11/15/2023
Status: ✅ Merged
Merged: 1/13/2024
Merged by: @NickeManarin

Base: dev ← Head: feature/1241-metered-network

📝 Commits (2)

db50646 Frontend changes:
3c37ec0 Backend changes:

📊 Changes

8 files changed (+42 additions, -5 deletions)

View changed files

📝 ScreenToGif.Util/Settings/UserSettings.cs (+6 -0)
📝 ScreenToGif/Resources/Localization/StringResources.en.xaml (+2 -0)
📝 ScreenToGif/Resources/Localization/StringResources.zh.xaml (+2 -0)
📝 ScreenToGif/Resources/Settings.xaml (+1 -0)
📝 ScreenToGif/Util/Other.cs (+22 -0)
📝 ScreenToGif/ViewModel/ApplicationViewModel.cs (+2 -1)
📝 ScreenToGif/Windows/Options.xaml (+5 -3)
📝 ScreenToGif/Windows/Options.xaml.cs (+2 -1)

📄 Description

Hello @NickeManarin ,
I've tried to implement this feature requested in #1241 , but I changed it a bit. Instead of don't check for updates, I only constrained the automatic download of new version.

The method to check if is in metered networks comes from here:
stackoverflow

But there brings a problem.
The WinRT API I used was introduced after Windows 10, so I had to change the target OS version to 10.0.17763.0, which will
likely make the product incompatible with old Windows version.
I'm still trying to find a way to make it version adaptive, any advice would be appreciated.
But for now I still want to create this PR for visibility.

Appreciate your time!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/1252 **Author:** [@GopherTheCoder](https://github.com/GopherTheCoder) **Created:** 11/15/2023 **Status:** ✅ Merged **Merged:** 1/13/2024 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `dev` ← **Head:** `feature/1241-metered-network` --- ### 📝 Commits (2) - [`db50646`](https://github.com/NickeManarin/ScreenToGif/commit/db506465ae715abc4a8d417443b9a89460ec5368) Frontend changes: - [`3c37ec0`](https://github.com/NickeManarin/ScreenToGif/commit/3c37ec01ed84a0251b321f1c37fa1b106e13bb86) Backend changes: ### 📊 Changes **8 files changed** (+42 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif.Util/Settings/UserSettings.cs` (+6 -0) 📝 `ScreenToGif/Resources/Localization/StringResources.en.xaml` (+2 -0) 📝 `ScreenToGif/Resources/Localization/StringResources.zh.xaml` (+2 -0) 📝 `ScreenToGif/Resources/Settings.xaml` (+1 -0) 📝 `ScreenToGif/Util/Other.cs` (+22 -0) 📝 `ScreenToGif/ViewModel/ApplicationViewModel.cs` (+2 -1) 📝 `ScreenToGif/Windows/Options.xaml` (+5 -3) 📝 `ScreenToGif/Windows/Options.xaml.cs` (+2 -1) </details> ### 📄 Description Hello @NickeManarin , I've tried to implement this feature requested in #1241 , but I changed it a bit. Instead of don't check for updates, I only constrained the automatic download of new version. The method to check if is in metered networks comes from here: [stackoverflow](https://stackoverflow.com/a/73316683) But there brings a problem. The WinRT API I used was introduced after Windows 10, so I had to change the target OS version to 10.0.17763.0, which will likely make the product incompatible with old Windows version. I'm still trying to find a way to make it version adaptive, any advice would be appreciated. But for now I still want to create this PR for visibility. Appreciate your time! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>