[PR #1046] [MERGED] Highlight mouse cursor even when no buttons are pressed #1294

New issue

Closed

opened 2026-02-26 09:34:19 +03:00 by kerem · 0 comments

kerem commented 2026-02-26 09:34:19 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/1046
Author: @zsee
Created: 1/8/2022
Status: ✅ Merged
Merged: 3/6/2022
Merged by: @NickeManarin

Base: dev ← Head: feature/highlight-mouse

---

📝 Commits (1)

• 4a67375 Feature: Highlight mouse cursor

📊 Changes

18 files changed (+213 additions, -110 deletions)

View changed files

📝 ScreenToGif.Model/Enums/PanelType.cs (+2 -2)
📝 ScreenToGif.Model/Enums/TaskTypes.cs (+1 -1)
📝 ScreenToGif.Util/Settings/Migrations.cs (+4 -0)
➕ ScreenToGif.Util/Settings/Migrations/Migration2_36_0To2_37_0.cs (+68 -0)
📝 ScreenToGif.Util/Settings/UserSettings.cs (+9 -3)
📝 ScreenToGif.ViewModel/Tasks/BaseTaskViewModel.cs (+2 -2)
📝 ScreenToGif.ViewModel/Tasks/MouseEventsViewModel.cs (+23 -13)
📝 ScreenToGif/Capture/DirectImageCapture.cs (+1 -1)
📝 ScreenToGif/Model/FrameInfo.cs (+1 -1)
📝 ScreenToGif/Resources/Commands.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.en.xaml (+4 -4)
📝 ScreenToGif/Resources/Settings.xaml (+5 -4)
📝 ScreenToGif/UserControls/MouseClicksPanel.xaml (+15 -11)
📝 ScreenToGif/UserControls/MouseClicksPanel.xaml.cs (+2 -2)
📝 ScreenToGif/Windows/Editor.xaml (+25 -20)
📝 ScreenToGif/Windows/Editor.xaml.cs (+45 -40)
📝 ScreenToGif/Windows/Other/AutomatedTask.xaml (+1 -1)
📝 ScreenToGif/Windows/Other/AutomatedTask.xaml.cs (+4 -4)

📄 Description

Hi!

This is a small change to the "Mouse Clicks" overlay feature: Adds a new setting to highlight the mouse cursor without clicks.
The name "Mouse Clicks" didn't seem appropriate anymore, so it's also renamed to "Mouse Events".

The highlight color is fully transparent by default, so it's not visible, and added a check to skip drawing transparent mouse overlays.

This is my first pull request, so I hope it's ok. :) Wasn't sure of the migrations part and what to do about the localization files.
Here are some screenshots:

closes #1086

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/1046 **Author:** [@zsee](https://github.com/zsee) **Created:** 1/8/2022 **Status:** ✅ Merged **Merged:** 3/6/2022 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `dev` ← **Head:** `feature/highlight-mouse` --- ### 📝 Commits (1) - [`4a67375`](https://github.com/NickeManarin/ScreenToGif/commit/4a67375e847bfbd7cb4e727f1f319a2517b0a2b5) Feature: Highlight mouse cursor ### 📊 Changes **18 files changed** (+213 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif.Model/Enums/PanelType.cs` (+2 -2) 📝 `ScreenToGif.Model/Enums/TaskTypes.cs` (+1 -1) 📝 `ScreenToGif.Util/Settings/Migrations.cs` (+4 -0) ➕ `ScreenToGif.Util/Settings/Migrations/Migration2_36_0To2_37_0.cs` (+68 -0) 📝 `ScreenToGif.Util/Settings/UserSettings.cs` (+9 -3) 📝 `ScreenToGif.ViewModel/Tasks/BaseTaskViewModel.cs` (+2 -2) 📝 `ScreenToGif.ViewModel/Tasks/MouseEventsViewModel.cs` (+23 -13) 📝 `ScreenToGif/Capture/DirectImageCapture.cs` (+1 -1) 📝 `ScreenToGif/Model/FrameInfo.cs` (+1 -1) 📝 `ScreenToGif/Resources/Commands.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.en.xaml` (+4 -4) 📝 `ScreenToGif/Resources/Settings.xaml` (+5 -4) 📝 `ScreenToGif/UserControls/MouseClicksPanel.xaml` (+15 -11) 📝 `ScreenToGif/UserControls/MouseClicksPanel.xaml.cs` (+2 -2) 📝 `ScreenToGif/Windows/Editor.xaml` (+25 -20) 📝 `ScreenToGif/Windows/Editor.xaml.cs` (+45 -40) 📝 `ScreenToGif/Windows/Other/AutomatedTask.xaml` (+1 -1) 📝 `ScreenToGif/Windows/Other/AutomatedTask.xaml.cs` (+4 -4) </details> ### 📄 Description Hi! This is a small change to the "Mouse Clicks" overlay feature: Adds a new setting to highlight the mouse cursor without clicks. The name "Mouse Clicks" didn't seem appropriate anymore, so it's also renamed to "Mouse Events". The highlight color is fully transparent by default, so it's not visible, and added a check to skip drawing transparent mouse overlays. This is my first pull request, so I hope it's ok. :) Wasn't sure of the migrations part and what to do about the localization files. Here are some screenshots:   closes #1086 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-26 09:34:19 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

dev

v2.40

2.43.1

2.43

2.42.1

2.42

2.41.5

2.41.4

2.41.3

2.41.2

2.41.1

2.41

2.40.1

2.40

2.39

2.38.1

2.38

2.37.2

2.37.1

2.37

2.36

2.35.4

2.35.3

2.35.2

2.35.1

2.35

2.34.1

2.34

2.33.1

2.33

2.32.1

2.32

2.31

2.30.1

2.30

2.29.1

2.29

2.28.2

2.28.1

2.28

2.27.3

2.27.2

2.27.1

2.27

2.26.1

2.26

2.25

2.24.2

2.24.1

2.24

2.23.2

2.23.1

2.23

2.22.1

2.22

2.21.2

2.21.1

2.21

2.20.4

2.20.3

2.20.2

2.20.1

2.20

2.19.3

2.19.2

2.19.1

2.19

2.18

2.17.1

2.17

2.16

2.15.2

2.15.1

2.15

2.14.1

2.14

2.13.3

2.13.2

2.13.1

2.13

2.12.1

2.12

2.11

2.10

2.9

2.8.1

2.8

2.7.3

2.7.2

2.7.1

2.7

2.6

2.5

2.4

2.3.2

2.3.1

2.3

2.2

2.1

Labels

Clear labels   

copy cats

  

duplicated

  

future feature

  

pull-request

Mirrored from GitHub Pull Request

  

⬜ Accepted

  

⬜ Completed

  

⬜ Help Wanted 💪

  

⬜ In Progress

  

⬜ Missing Details

  

⬜ Pending

  

⬜ Waiting For Answer ⏳

  

🆕 feature preview

  

🔷 Bug 🐛

  

🔷 Out Of Scope

  

🔷 Out Of Scope

  

🔷 Question

  

🔷Enhancement

  

🔷Enhancement

  

🔷Invalid / External

  

🔷Knowledge Base

  

🔷Won't Fix

  

🕑 High

  

🕑 High

  

🕑 High

  

🕕 Medium

  

🕙 Low

  

🕛 Critical

No labels

copy cats

duplicated

future feature

pull-request

⬜ Accepted

⬜ Completed

⬜ Help Wanted 💪

⬜ In Progress

⬜ Missing Details

⬜ Pending

⬜ Waiting For Answer ⏳

🆕 feature preview

🔷 Bug 🐛

🔷 Out Of Scope

🔷 Out Of Scope

🔷 Question

🔷Enhancement

🔷Enhancement

🔷Invalid / External

🔷Knowledge Base

🔷Won't Fix

🕑 High

🕑 High

🕑 High

🕕 Medium

🕙 Low

🕛 Critical

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1294

No description provided.