[PR #198] [MERGED] Sanitise OutputFilename before attempting to open explorer #1086

Closed
opened 2026-02-26 09:33:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/198
Author: @PromoFaux
Created: 10/22/2017
Status: Merged
Merged: 10/22/2017
Merged by: @NickeManarin

Base: masterHead: master


📝 Commits (1)

  • b0cd598 Replace / chars with \ in OutputFilename

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ScreenToGif/Controls/EncoderListViewItem.cs (+1 -1)

📄 Description

(Redo of previous #197)

Noticed OutputFilename was populated wrongly (perhaps):
image

This is a quick fix to ensure that explorer will open in the right place.
fixed

Bonus: Here is the project file for the gif above
project.zip


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/198 **Author:** [@PromoFaux](https://github.com/PromoFaux) **Created:** 10/22/2017 **Status:** ✅ Merged **Merged:** 10/22/2017 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b0cd598`](https://github.com/NickeManarin/ScreenToGif/commit/b0cd598d7d9fff928d1cd9e2a1178e442288cc51) Replace `/` chars with `\` in OutputFilename ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Controls/EncoderListViewItem.cs` (+1 -1) </details> ### 📄 Description (Redo of previous #197) Noticed `OutputFilename` was populated wrongly (perhaps): ![image](https://user-images.githubusercontent.com/1998970/31866702-7483808e-b77b-11e7-8c7e-f3931ebb9a60.png) This is a quick fix to ensure that explorer will open in the right place. ![fixed](https://user-images.githubusercontent.com/1998970/31866708-8faff4f0-b77b-11e7-9314-313b523db4d4.gif) Bonus: Here is the project file for the gif above [project.zip](https://github.com/NickeManarin/ScreenToGif/files/1405381/project.zip) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 09:33:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#1086
No description provided.