[PR #370] [MERGED] A lot of bug fixes to previous release #451

New issue

Closed

opened 2026-02-28 01:24:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/370
Author: @eyedol
Created: 2/12/2016
Status: ✅ Merged
Merged: 2/12/2016
Merged by: @eyedol

Base: master ← Head: 364-secret-key-getting-duplicated

📝 Commits (2)

d53a0be A lot of bug fixes to previous release
1022d73 Update changelog

📊 Changes

63 files changed (+1398 additions, -660 deletions)

View changed files

📝 build.gradle (+7 -3)
📝 changelog.json (+11 -0)
📝 dependencies/dependencies.gradle (+7 -12)
📝 gradle/wrapper/gradle-wrapper.properties (+2 -2)
📝 smssync/build.gradle (+2 -5)
📝 smssync/src/internal/java/org/addhen/smssync/data/repository/InternalFilterDataRepository.java (+8 -8)
📝 smssync/src/main/java/org/addhen/smssync/data/cache/FileManager.java (+3 -3)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/Filter.java (+26 -2)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/Log.java (+17 -1)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/Message.java (+116 -12)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/MessageResult.java (+0 -12)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/mapper/FilterDataMapper.java (+6 -6)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/mapper/LogDataMapper.java (+3 -3)
📝 smssync/src/main/java/org/addhen/smssync/data/entity/mapper/MessageDataMapper.java (+24 -23)
📝 smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java (+50 -116)
📝 smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessage.java (+61 -46)
📝 smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java (+7 -4)
📝 smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java (+21 -88)
📝 smssync/src/main/java/org/addhen/smssync/data/net/AppHttpClient.java (+6 -0)
📝 smssync/src/main/java/org/addhen/smssync/data/net/MessageHttpClient.java (+6 -4)

...and 43 more files

📄 Description

Remove the use of robolectric for unit testing. Now android ships
native unit testing support.
Refactor entities to use getters and setters so they can be mocked.
Add test for post message.
Add test for single and multiple messages synchronization.
Fix #362 - Use the device's phone number for the sent_to
field instead of the from number.
Fix #369 - Set imported messages from the phone's inbox type
to pending and status to failure. This prevents the app
from crashing when an attempt is made to fetch messages from the app's
inbox.
Swipe to manually sync individual messages in the pending list is
is broken because there was no method call to cause the sync.
Made a call to publishItem(int position) when a swipe occurs.
Add test for IP based Integration.
When Test Ingeration button is hit, the app makes a request using
configured request method to the server. The test request doesn't
send the message and from variables to the server. This sometimes
causes validation error when the server is strict about those two
parameters. This sometimes leads to testing of the integration to
report invalid endpoint has been entered. To fix this, added a
hardcoded message and from values so those are sent along with the
secret values. This actually makes the test report that the
configured integration can actually receive messages from the app.
Upgrade android gradle plugin

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/370 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 2/12/2016 **Status:** ✅ Merged **Merged:** 2/12/2016 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `364-secret-key-getting-duplicated` --- ### 📝 Commits (2) - [`d53a0be`](https://github.com/ushahidi/SMSSync/commit/d53a0be6660874f39924cfff40941320b578a833) A lot of bug fixes to previous release - [`1022d73`](https://github.com/ushahidi/SMSSync/commit/1022d73c624d9300b29af8241527f8a340743c27) Update changelog ### 📊 Changes **63 files changed** (+1398 additions, -660 deletions) <details> <summary>View changed files</summary> 📝 `build.gradle` (+7 -3) 📝 `changelog.json` (+11 -0) 📝 `dependencies/dependencies.gradle` (+7 -12) 📝 `gradle/wrapper/gradle-wrapper.properties` (+2 -2) 📝 `smssync/build.gradle` (+2 -5) 📝 `smssync/src/internal/java/org/addhen/smssync/data/repository/InternalFilterDataRepository.java` (+8 -8) 📝 `smssync/src/main/java/org/addhen/smssync/data/cache/FileManager.java` (+3 -3) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/Filter.java` (+26 -2) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/Log.java` (+17 -1) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/Message.java` (+116 -12) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/MessageResult.java` (+0 -12) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/mapper/FilterDataMapper.java` (+6 -6) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/mapper/LogDataMapper.java` (+3 -3) 📝 `smssync/src/main/java/org/addhen/smssync/data/entity/mapper/MessageDataMapper.java` (+24 -23) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java` (+50 -116) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessage.java` (+61 -46) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java` (+7 -4) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java` (+21 -88) 📝 `smssync/src/main/java/org/addhen/smssync/data/net/AppHttpClient.java` (+6 -0) 📝 `smssync/src/main/java/org/addhen/smssync/data/net/MessageHttpClient.java` (+6 -4) _...and 43 more files_ </details> ### 📄 Description - Remove the use of robolectric for unit testing. Now android ships native unit testing support. - Refactor entities to use getters and setters so they can be mocked. - Add test for post message. - Add test for single and multiple messages synchronization. - Fix #362 - Use the device's phone number for the `sent_to` field instead of the `from` number. - Fix #369 - Set imported messages from the phone's inbox `type` to `pending` and `status` to failure. This prevents the app from crashing when an attempt is made to fetch messages from the app's inbox. - Swipe to manually sync individual messages in the pending list is is broken because there was no method call to cause the sync. Made a call to `publishItem(int position)` when a swipe occurs. - Add test for IP based Integration. - When Test Ingeration button is hit, the app makes a request using configured request method to the server. The test request doesn't send the `message` and `from` variables to the server. This sometimes causes validation error when the server is strict about those two parameters. This sometimes leads to testing of the integration to report invalid endpoint has been entered. To fix this, added a hardcoded message and from values so those are sent along with the secret values. This actually makes the test report that the configured integration can actually receive messages from the app. - Upgrade android gradle plugin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>