[PR #83] [MERGED] cleanup and bugfix #362

New issue

Closed

opened 2026-02-28 01:24:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/83
Author: @mandric
Created: 3/30/2013
Status: ✅ Merged
Merged: 4/3/2013
Merged by: @eyedol

Base: develop ← Head: develop

📝 Commits (3)

93d9c9c minor cleanup
28e0d0a fixed bug when syncing pending messages but service is not running
f051075 remove unused param from routeSms() and cleaned up some comments.

📊 Changes

9 files changed (+135 additions, -118 deletions)

View changed files

📝 smssync/src/org/addhen/smssync/ProcessSms.java (+86 -98)
📝 smssync/src/org/addhen/smssync/fragments/PendingMessages.java (+33 -9)
📝 smssync/src/org/addhen/smssync/fragments/SyncUrl.java (+1 -1)
📝 smssync/src/org/addhen/smssync/services/AutoSyncScheduledService.java (+1 -1)
📝 smssync/src/org/addhen/smssync/services/AutoSyncService.java (+1 -1)
📝 smssync/src/org/addhen/smssync/services/SmsReceiverService.java (+8 -3)
📝 smssync/src/org/addhen/smssync/services/SyncPendingMessagesService.java (+2 -2)
📝 smssync/src/org/addhen/smssync/util/MessageSyncUtil.java (+2 -2)
📝 smssync/src/org/addhen/smssync/util/ServicesConstants.java (+1 -1)

📄 Description

Cleaned up a few things and fixed a bug as you can see in the commit message.

Also was trying to debug a crash/unstable activity when syncing a lot of pending messages (> 300) after an import all at once. I should/will open an issue for that soon unless you want to try to replicate that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/83 **Author:** [@mandric](https://github.com/mandric) **Created:** 3/30/2013 **Status:** ✅ Merged **Merged:** 4/3/2013 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (3) - [`93d9c9c`](https://github.com/ushahidi/SMSSync/commit/93d9c9c0c68992c12f39830bf8b2e60364a4974c) minor cleanup - [`28e0d0a`](https://github.com/ushahidi/SMSSync/commit/28e0d0ac6be168041e4b0ad457f13fe641176812) fixed bug when syncing pending messages but service is not running - [`f051075`](https://github.com/ushahidi/SMSSync/commit/f051075d728e390463900867ebd0742ad1c9dfcb) remove unused param from routeSms() and cleaned up some comments. ### 📊 Changes **9 files changed** (+135 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `smssync/src/org/addhen/smssync/ProcessSms.java` (+86 -98) 📝 `smssync/src/org/addhen/smssync/fragments/PendingMessages.java` (+33 -9) 📝 `smssync/src/org/addhen/smssync/fragments/SyncUrl.java` (+1 -1) 📝 `smssync/src/org/addhen/smssync/services/AutoSyncScheduledService.java` (+1 -1) 📝 `smssync/src/org/addhen/smssync/services/AutoSyncService.java` (+1 -1) 📝 `smssync/src/org/addhen/smssync/services/SmsReceiverService.java` (+8 -3) 📝 `smssync/src/org/addhen/smssync/services/SyncPendingMessagesService.java` (+2 -2) 📝 `smssync/src/org/addhen/smssync/util/MessageSyncUtil.java` (+2 -2) 📝 `smssync/src/org/addhen/smssync/util/ServicesConstants.java` (+1 -1) </details> ### 📄 Description Cleaned up a few things and fixed a bug as you can see in the commit message. Also was trying to debug a crash/unstable activity when syncing a lot of pending messages (> 300) after an import all at once. I should/will open an issue for that soon unless you want to try to replicate that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>