[PR #789] [CLOSED] Added Support for custom passworded certificates. #1184

New issue

Closed

opened 2026-02-27 15:53:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:53:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/789
Author: @ndragon798
Created: 12/4/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

85c89f0 Added support for passworded custom .p12 certs.
84b7719 Added importing passworded certificates.

📊 Changes

15 files changed (+923 additions, -39 deletions)

View changed files

📝 .gitignore (+7 -1)
📝 Quasar.Client/Config/Settings.cs (+4 -4)
📝 Quasar.Common/Cryptography/Sha256.cs (+28 -0)
📝 Quasar.Server/Build/ClientBuilder.cs (+11 -4)
➕ Quasar.Server/Forms/FrmCertPass.Designer.cs (+87 -0)
➕ Quasar.Server/Forms/FrmCertPass.cs (+19 -0)
➕ Quasar.Server/Forms/FrmCertPass.resx (+659 -0)
📝 Quasar.Server/Forms/FrmCertificate.cs (+27 -7)
📝 Quasar.Server/Forms/FrmMain.cs (+1 -1)
📝 Quasar.Server/Forms/FrmSettings.Designer.cs (+42 -18)
📝 Quasar.Server/Forms/FrmSettings.cs (+7 -0)
📝 Quasar.Server/Helper/CertificateHelper.cs (+7 -2)
📝 Quasar.Server/Models/Settings.cs (+12 -0)
📝 Quasar.Server/Networking/QuasarServer.cs (+3 -2)
📝 Quasar.Server/Quasar.Server.csproj (+9 -0)

📄 Description

Added the support for custom passworded certificates to do this I had to implement sha1 into both the client and server and change most of the calls for the certs to also pull the password in settings.

I see one improvement from this that would be not storing the cert pass in plain text but that would require adding a password field to the entire program and then using that password to hash the settings.xml

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/789 **Author:** [@ndragon798](https://github.com/ndragon798) **Created:** 12/4/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`85c89f0`](https://github.com/quasar/Quasar/commit/85c89f0ca280f34d41d57c753e7d5e78d9cf6ff9) Added support for passworded custom .p12 certs. - [`84b7719`](https://github.com/quasar/Quasar/commit/84b7719aba1050c6d847784ee35dc2b521bc570a) Added importing passworded certificates. ### 📊 Changes **15 files changed** (+923 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+7 -1) 📝 `Quasar.Client/Config/Settings.cs` (+4 -4) 📝 `Quasar.Common/Cryptography/Sha256.cs` (+28 -0) 📝 `Quasar.Server/Build/ClientBuilder.cs` (+11 -4) ➕ `Quasar.Server/Forms/FrmCertPass.Designer.cs` (+87 -0) ➕ `Quasar.Server/Forms/FrmCertPass.cs` (+19 -0) ➕ `Quasar.Server/Forms/FrmCertPass.resx` (+659 -0) 📝 `Quasar.Server/Forms/FrmCertificate.cs` (+27 -7) 📝 `Quasar.Server/Forms/FrmMain.cs` (+1 -1) 📝 `Quasar.Server/Forms/FrmSettings.Designer.cs` (+42 -18) 📝 `Quasar.Server/Forms/FrmSettings.cs` (+7 -0) 📝 `Quasar.Server/Helper/CertificateHelper.cs` (+7 -2) 📝 `Quasar.Server/Models/Settings.cs` (+12 -0) 📝 `Quasar.Server/Networking/QuasarServer.cs` (+3 -2) 📝 `Quasar.Server/Quasar.Server.csproj` (+9 -0) </details> ### 📄 Description Added the support for custom passworded certificates to do this I had to implement sha1 into both the client and server and change most of the calls for the certs to also pull the password in settings. I see one improvement from this that would be not storing the cert pass in plain text but that would require adding a password field to the entire program and then using that password to hash the settings.xml --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>