[GH-ISSUE #693] Clearing does not update count #691

Open
opened 2026-03-03 19:21:01 +03:00 by kerem · 5 comments
Owner

Originally created by @CyberMew on GitHub (Nov 15, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/693

Proxyman version? (Ex. Proxyman 1.4.3)

2.12.0

macOS Version? (Ex. mac 10.14)

all

Steps to reproduce

Click on Clear button

Expected behavior

Requests on screen to be cleared, regardless of what sidebar (app, domain, pinned) we selected, and whether or not we also cleared the filtered the results.
Domain count to be updated correctly. If I am viewing Domains and I have 2 domain, I filter for 1 domain, I clear the screen, then domain count should be 1. If I did not filter, and I clear it, domain count will be 0.

Current behavior

Count does not updated at all. Clearing of filtered results seems fine, no hopefully no issue there.

Screenshots (optional)

image
image

Originally created by @CyberMew on GitHub (Nov 15, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/693 ### Proxyman version? (Ex. Proxyman 1.4.3) 2.12.0 ### macOS Version? (Ex. mac 10.14) all ### Steps to reproduce Click on Clear button ### Expected behavior Requests on screen to be cleared, regardless of what sidebar (app, domain, pinned) we selected, and whether or not we also cleared the filtered the results. Domain count to be updated correctly. If I am viewing Domains and I have 2 domain, I filter for 1 domain, I clear the screen, then domain count should be 1. If I did not filter, and I clear it, domain count will be 0. ### Current behavior Count does not updated at all. Clearing of filtered results seems fine, no hopefully no issue there. ### Screenshots (optional) ![image](https://user-images.githubusercontent.com/4715911/99162405-72a50000-2738-11eb-8ad3-f220a26b85f8.png) ![image](https://user-images.githubusercontent.com/4715911/99162480-3a51f180-2739-11eb-9cb6-8cc042de0f78.png)
Author
Owner

@NghiaTranUIT commented on GitHub (Nov 15, 2020):

It's correct behavior @CyberMew 😄

The count number is the sub-nodes inside this folder. For instance, 616 is the number of the domain inside the Domains folder.

It's not the number of the flow of the current view, which has the Clear button.

Therefore, if you hit the Clear button, it will clear all requests from the current List, not remove the domain folder.


To clear 616, you may click on the Clear session button on the Top Navigation Bar 👍

<!-- gh-comment-id:727418333 --> @NghiaTranUIT commented on GitHub (Nov 15, 2020): It's correct behavior @CyberMew 😄 The count number is the sub-nodes inside this folder. For instance, 616 is the number of the domain inside the Domains folder. It's not the number of the flow of the current view, which has the Clear button. Therefore, if you hit the Clear button, it will clear all requests from the current List, not remove the domain folder. -------------------- To clear 616, you may click on the Clear session button on the Top Navigation Bar 👍
Author
Owner

@CyberMew commented on GitHub (Nov 15, 2020):

Hi @NghiaTranUIT, the Domains shows 616, but the list is empty. I have some pinned domains but definitely not more than 10. Showing 616 in this case is considered correct behaviour? I am not expecting to see 616 (sub-nodes) since there is no way I can access them anymore.

<!-- gh-comment-id:727595997 --> @CyberMew commented on GitHub (Nov 15, 2020): Hi @NghiaTranUIT, the Domains shows 616, but the list is empty. I have some pinned domains but definitely not more than 10. Showing 616 in this case is considered correct behaviour? I am not expecting to see 616 (sub-nodes) since there is no way I can access them anymore.
Author
Owner

@NghiaTranUIT commented on GitHub (Nov 15, 2020):

Can you click on the Triangle arrow? It will expand the subnode 😄

<!-- gh-comment-id:727596716 --> @NghiaTranUIT commented on GitHub (Nov 15, 2020): Can you click on the Triangle arrow? It will expand the subnode 😄
Author
Owner

@CyberMew commented on GitHub (Nov 18, 2020):

Ah ok. Yes, it expanded with all the domain names, but inside each of then, it is blank. There are no http request entries inside. So is the app supposed to retain all the subnodes with nothing inside after clicking on Clear?

<!-- gh-comment-id:729347790 --> @CyberMew commented on GitHub (Nov 18, 2020): Ah ok. Yes, it expanded with all the domain names, but inside each of then, it is blank. There are no http request entries inside. So is the app supposed to retain all the subnodes with nothing inside after clicking on Clear?
Author
Owner

@NghiaTranUIT commented on GitHub (Nov 18, 2020):

Yes, it's correct. The scope of the Clear button is just the selected node (on the left). It means it will clear all flows in the Middle Table. It doesn't affect other nodes (in the left panel).

If you click Clear Session, it will clear all, and the count number will reset to 0, since all nodes are wiped out.

Screen_Shot_2020-11-18_at_10_19_05

I understand that it's a little confusing, but it's essential to separate it since many users do not want to clear all, they just need to clear the current table view.

<!-- gh-comment-id:729351660 --> @NghiaTranUIT commented on GitHub (Nov 18, 2020): Yes, it's correct. The scope of the Clear button is just the selected node (on the left). It means it will clear all flows in the Middle Table. It doesn't affect other nodes (in the left panel). If you click Clear Session, it will clear all, and the count number will reset to 0, since all nodes are wiped out. <img width="510" alt="Screen_Shot_2020-11-18_at_10_19_05" src="https://user-images.githubusercontent.com/5878421/99478762-90b46f80-2987-11eb-9abc-f8245d983934.png"> I understand that it's a little confusing, but it's essential to separate it since many users do not want to clear all, they just need to clear the current table view.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#691
No description provided.