mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-27 00:55:57 +03:00
[GH-ISSUE #405] "Clear" button does not reset the count in the left pane #403
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#403
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kspeeckaert on GitHub (Feb 23, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/405
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
Proxyman 1.16.0
macOS Version? (Ex. mac 10.14)
Mac OS X 10.15.3
Steps to reproduce
Expected behaviour
Screenshots (optional)
@NghiaTranUIT commented on GitHub (Feb 23, 2020):
Hey there, the
11number is the number of its sub-nodes, not the number of total items in this Folder. As a result, the clear button doesn't reset the count.If you would to remove the sub-nodes, you can expand the folder, select all, and hit Delete. The number will be reset 👍
@kspeeckaert commented on GitHub (Feb 23, 2020):
Thanks for the clarification. But it feels a little counter-intuitive as I expected the left pane to be a (structured) representation of the right pane.
When the right pane is cleared by pressing the Clear button, there are indeed sub-nodes as you mentioned. Expanding those will show e.g. the applications and beneath that the domains they accessed. But when I select any of them, there isn't anything showing up on the right anymore (as I cleared them earlier). So I'm a little lost as to what the point is of keeping them and having to delete them manually.
Don't get me wrong, I think the structuring on the left is an excellent idea as it gives a clear oversight and an easy way to filter specific apps/domains, but I would've expected the left and the right pane to stay in sync.
Let me clarify the workflow I had in mind: if I want to quickly clear the current data (e.g. imagine having started Proxyman, but it already started capturing network traffic before you had your test case ready, or if you are between test cases and want to "reset" the current data), I have to:
The alternative is to open a new tab and leave the current one open or close it.
@kspeeckaert commented on GitHub (Feb 23, 2020):
While I was playing around with the left pane, I noticed a discrepancy when using the Clear button having an application selected. To clarify things, I made a screen recording.
You'll notice that when clearing the entries while having an app selected, going back to the All top node will reveal all entries again.
@NghiaTranUIT commented on GitHub (Feb 23, 2020):
It's the problem we're facing too. Technically:
=> It's for performance purpose. As we select any node, it will immediately render the array of flows without accumulating flows from sub-nodes.
For that reason, when we clear the array of flows in particular sub-nodes. It's a heavy task to go back to all parent nodes and remove it from the array if we have 1000-2000 flows (usual cases).
As a result, we consider removing the flows in this node, but not for the parent => The
All folderstill have it.