[GH-ISSUE #409] [BUG] Reversed ID sort causes selected row to change when request comes in #405

Closed
opened 2026-03-03 19:18:18 +03:00 by kerem · 9 comments
Owner

Originally created by @ptrkstr on GitHub (Feb 24, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/409

Originally assigned to: @NghiaTranUIT on GitHub.

Proxyman version? (Ex. Proxyman 1.4.3)

1.16.0 (11600)

macOS Version? (Ex. mac 10.14)

10.15.3 (19D76)

Steps to reproduce

  1. Have requests coming in
  2. Flip the ID sort
  3. Select a row
  4. Wait for another request to come in
  5. Notice that the row you previously had selected has changed

Expected behavior

Selected row doesn't change

Screenshots (optional)

Demonstration: https://imgur.com/ftFuTHT

Originally created by @ptrkstr on GitHub (Feb 24, 2020). Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/409 Originally assigned to: @NghiaTranUIT on GitHub. ### Proxyman version? (Ex. Proxyman 1.4.3) 1.16.0 (11600) ### macOS Version? (Ex. mac 10.14) 10.15.3 (19D76) ### Steps to reproduce 1. Have requests coming in 1. Flip the ID sort 1. Select a row 1. Wait for another request to come in 1. Notice that the row you previously had selected has changed ### Expected behavior Selected row doesn't change ### Screenshots (optional) Demonstration: https://imgur.com/ftFuTHT
kerem 2026-03-03 19:18:18 +03:00
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 24, 2020):

Thank you. I just opened the ticket too https://github.com/ProxymanApp/Proxyman/issues/408 😄

<!-- gh-comment-id:590177856 --> @NghiaTranUIT commented on GitHub (Feb 24, 2020): Thank you. I just opened the ticket too https://github.com/ProxymanApp/Proxyman/issues/408 😄
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 24, 2020):

I will mention you when the bug is fixed 🙌

<!-- gh-comment-id:590177909 --> @NghiaTranUIT commented on GitHub (Feb 24, 2020): I will mention you when the bug is fixed 🙌
Author
Owner

@ptrkstr commented on GitHub (Feb 24, 2020):

Wow! We created it within a minute of each other 😮

<!-- gh-comment-id:590182197 --> @ptrkstr commented on GitHub (Feb 24, 2020): Wow! We created it within a minute of each other 😮
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 24, 2020):

Hey @patrickbdev

Let try a beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.16.0_Fix_Selection_Jump.dmg

I change the behavior:

  • If you’re selecting the first row and sort by ID then the new flow is appended at the top -> It will automatically select the top -> The Request/Response panel is updated.
    It’s our intention since you can get the new response without clicking on the top again. (Some users requested it)
  • If you’re select different rows (not the first), the selection is maintained (Fix your bug here).

I will release the fix tmr.

Please let me know if it works for you 🙌

<!-- gh-comment-id:590408940 --> @NghiaTranUIT commented on GitHub (Feb 24, 2020): Hey @patrickbdev Let try a beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.16.0_Fix_Selection_Jump.dmg I change the behavior: - If you’re selecting the first row and sort by ID then the new flow is appended at the top -> It will automatically select the top -> The Request/Response panel is updated. It’s our intention since you can get the new response without clicking on the top again. (Some users requested it) - If you’re select different rows (not the first), the selection is maintained (Fix your bug here). I will release the fix tmr. Please let me know if it works for you 🙌
Author
Owner

@ptrkstr commented on GitHub (Feb 25, 2020):

Thanks @NghiaTranUIT that does fix my problem.
I did want to make a comment about this change:

If you’re selecting the first row and sort by ID then the new flow is appended at the top -> It will automatically select the top -> The Request/Response panel is updated.
It’s our intention since you can get the new response without clicking on the top again. (Some users requested it)

This doesn't seem to follow macOS convention. You can test this by:

  1. Opening Finder
  2. Selecting a row
  3. Change the sorting by name
  4. You'll notice that the item you had highlighted is still highlighted

I would recommend Proxyman's behaviour matching that what users are used to on macOS.

<!-- gh-comment-id:590656356 --> @ptrkstr commented on GitHub (Feb 25, 2020): Thanks @NghiaTranUIT that does fix my problem. I did want to make a comment about this change: >If you’re selecting the first row and sort by ID then the new flow is appended at the top -> It will automatically select the top -> The Request/Response panel is updated. It’s our intention since you can get the new response without clicking on the top again. (Some users requested it) This doesn't seem to follow macOS convention. You can test this by: 1. Opening Finder 1. Selecting a row 1. Change the sorting by name 1. You'll notice that the item you had highlighted is still highlighted I would recommend Proxyman's behaviour matching that what users are used to on macOS.
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 25, 2020):

At the initial implementation, I did the same behavior with macOS. But it turns out that the case of Proxyman is slightly different when there are new requests are coming, and there is a need that I would get the last Request/Response data in the Content Panel.

Regarding your reproducible steps, I notice it's a small bug. When sorting, I completely reload the table -> The current selection is reset unexpectedly 😬 I'm fixing it now 🙌

<!-- gh-comment-id:590660022 --> @NghiaTranUIT commented on GitHub (Feb 25, 2020): At the initial implementation, I did the same behavior with macOS. But it turns out that the case of Proxyman is slightly different when there are new requests are coming, and there is a need that I would get the last Request/Response data in the Content Panel. Regarding your reproducible steps, I notice it's a small bug. When sorting, I completely reload the table -> The current selection is reset unexpectedly 😬 I'm fixing it now 🙌
Author
Owner

@ptrkstr commented on GitHub (Feb 27, 2020):

@NghiaTranUIT
For this

Regarding your reproducible steps, I notice it's a small bug. When sorting, I completely reload the table -> The current selection is reset unexpectedly 😬 I'm fixing it now 🙌

Did you want me to open up a separate issue (or no need to) so we can close this one?

<!-- gh-comment-id:591711055 --> @ptrkstr commented on GitHub (Feb 27, 2020): @NghiaTranUIT For this > Regarding your reproducible steps, I notice it's a small bug. When sorting, I completely reload the table -> The current selection is reset unexpectedly 😬 I'm fixing it now 🙌 Did you want me to open up a separate issue (or no need to) so we can close this one?
Author
Owner

@NghiaTranUIT commented on GitHub (Feb 27, 2020):

All done here @patrickbdev https://github.com/ProxymanApp/Proxyman/issues/417

Thank you for bumping it 🎉

<!-- gh-comment-id:591745671 --> @NghiaTranUIT commented on GitHub (Feb 27, 2020): All done here @patrickbdev https://github.com/ProxymanApp/Proxyman/issues/417 Thank you for bumping it 🎉
Author
Owner

@ptrkstr commented on GitHub (Feb 28, 2020):

Thank you @NghiaTranUIT

<!-- gh-comment-id:592256845 --> @ptrkstr commented on GitHub (Feb 28, 2020): Thank you @NghiaTranUIT
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Proxyman#405
No description provided.