mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-27 09:05:54 +03:00
[GH-ISSUE #409] [BUG] Reversed ID sort causes selected row to change when request comes in #405
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#405
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ptrkstr on GitHub (Feb 24, 2020).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/409
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
1.16.0 (11600)
macOS Version? (Ex. mac 10.14)
10.15.3 (19D76)
Steps to reproduce
Expected behavior
Selected row doesn't change
Screenshots (optional)
Demonstration: https://imgur.com/ftFuTHT
@NghiaTranUIT commented on GitHub (Feb 24, 2020):
Thank you. I just opened the ticket too https://github.com/ProxymanApp/Proxyman/issues/408 😄
@NghiaTranUIT commented on GitHub (Feb 24, 2020):
I will mention you when the bug is fixed 🙌
@ptrkstr commented on GitHub (Feb 24, 2020):
Wow! We created it within a minute of each other 😮
@NghiaTranUIT commented on GitHub (Feb 24, 2020):
Hey @patrickbdev
Let try a beta build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.16.0_Fix_Selection_Jump.dmg
I change the behavior:
It’s our intention since you can get the new response without clicking on the top again. (Some users requested it)
I will release the fix tmr.
Please let me know if it works for you 🙌
@ptrkstr commented on GitHub (Feb 25, 2020):
Thanks @NghiaTranUIT that does fix my problem.
I did want to make a comment about this change:
This doesn't seem to follow macOS convention. You can test this by:
I would recommend Proxyman's behaviour matching that what users are used to on macOS.
@NghiaTranUIT commented on GitHub (Feb 25, 2020):
At the initial implementation, I did the same behavior with macOS. But it turns out that the case of Proxyman is slightly different when there are new requests are coming, and there is a need that I would get the last Request/Response data in the Content Panel.
Regarding your reproducible steps, I notice it's a small bug. When sorting, I completely reload the table -> The current selection is reset unexpectedly 😬 I'm fixing it now 🙌
@ptrkstr commented on GitHub (Feb 27, 2020):
@NghiaTranUIT
For this
Did you want me to open up a separate issue (or no need to) so we can close this one?
@NghiaTranUIT commented on GitHub (Feb 27, 2020):
All done here @patrickbdev https://github.com/ProxymanApp/Proxyman/issues/417
Thank you for bumping it 🎉
@ptrkstr commented on GitHub (Feb 28, 2020):
Thank you @NghiaTranUIT