mirror of
https://github.com/ProxymanApp/Proxyman.git
synced 2026-04-26 00:25:56 +03:00
[GH-ISSUE #357] Some urls are not shown in proxy #354
Labels
No labels
Discussion
Feature request
In Progress...
Plugins
Waiting response
Windows
Windows
bug
duplicate
enhancement
feature
good first issue
iOS
macOS 10.11
question
wontfix
✅ Done
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Proxyman#354
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Schaefers on GitHub (Dec 20, 2019).
Original GitHub issue: https://github.com/ProxymanApp/Proxyman/issues/357
Originally assigned to: @NghiaTranUIT on GitHub.
Proxyman version? (Ex. Proxyman 1.4.3)
Proxyman 1.11.0
macOS Version? (Ex. mac 10.14)
mac 10.15.2
Steps to reproduce
Expected behavior
The call should be shown in the list
Additional hints
These calls are performed via mobile apps, if accessing the url using a browser, the special characters are automatically encoded. As a result they are shown in Proxyman.
@NghiaTranUIT commented on GitHub (Dec 20, 2019):
It looks like this request is failed because the URL doesn't properly encode with Percent-Encoding) when going through the Proxyman -> Doesn't appear on the app.
I just tested this URL with curl and Insomnia. It automatically encoded, so it works in Proxyman.
About mobile app, do you use NSURLSession or Alamofire to construct this URL 🤔? I would like to reproduce in iOS app for easier fixing it.
@NghiaTranUIT commented on GitHub (Dec 20, 2019):
On the other hand, I will improve how Proxyman handles the failed requests to make sure that it still visible on the app even though it's failed.
@Schaefers commented on GitHub (Dec 20, 2019):
In the mobile app we're using Alamofire for iOS and Fuel for Android.
Thanks in advance.
@NghiaTranUIT commented on GitHub (Dec 20, 2019):
Thank. Let me try to disable URL-Encoding in Alamofire and investigate it 👍
Question: Why don't we encode the URL before sending? Since percent-encoded is universally accepted in many web-browser and server.
@Schaefers commented on GitHub (Dec 20, 2019):
I tested again with the iOS App and this request is properly shown, maybe it's related to Fuel on Android..
@NghiaTranUIT commented on GitHub (Dec 20, 2019):
Glad to hear that. Let me know the result on Android build 👍
@Schaefers commented on GitHub (Dec 20, 2019):
I‘m not responsible for the Android app, so it might take some time to test it. But I know from one of our Android developers, that this call works with Charles or mitm-Proxy, so it seems to be a bug on your end.
@NghiaTranUIT commented on GitHub (Dec 20, 2019):
Sure, I will investigate by disabling the Percent-encoding 👍
@ghost commented on GitHub (Dec 29, 2019):
Same issue is with Google Fonts.
This URL is showing in Proxyman and it loads fine:
https://fonts.googleapis.com/css?family=Roboto:300
However this URL does not load and also not showing in Proxyman
https://fonts.googleapis.com/css?family=Roboto:300|Google+Sans
Because of this issue we are unable to debug our web apps. Most of our apps use Google Fonts and when proxy is enabled, the web app does not load.
@NghiaTranUIT commented on GitHub (Dec 29, 2019):
Thank for the hint. I suppose that the parser couldn't parse the
|, which results the error.I'm on it now
@NghiaTranUIT commented on GitHub (Dec 29, 2019):
@vimalkaul Thank you for the link: https://fonts.googleapis.com/css?family=Roboto:300|Google+Sans
I'm able to reproduce it in my machine. Perfect time to squash it 🐛 💥
@NghiaTranUIT commented on GitHub (Dec 29, 2019):
Hey @vimalkaul @Schaefers here is the BETA build: https://proxyman.s3.us-east-2.amazonaws.com/beta/Proxyman_1.11.0_Decode_percented_in_invalid_query.dmg
In this build, I would try to do percented-encoding for URLs, which contain invalid characters by following RFC 3986
I tested both Google API URLs and it works well.
Please let me know if it works. If not, please help me to print out the URL. I would investigate more 👍
Thank you guys 🎉
@ghost commented on GitHub (Dec 30, 2019):
Hi @NghiaTranUIT checked build with URLs I had shared and with our web apps. This build is working fine. Thanks for looking into it and fixing the issue.
Thanks,
Vimal Kaul
@NghiaTranUIT commented on GitHub (Dec 30, 2019):
Cool. Glad to hear that. I will officially release the build in this week 👍