starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #1052] [CLOSED] feat: allow adding SSH authorized key for root (advanced settings) #2992

New issue

Closed

opened 2026-02-26 13:32:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:32:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1052
Author: @dsiebel
Created: 12/27/2024
Status: ❌ Closed

Base: develop ← Head: ssh-authorized-key

📝 Commits (10+)

e2aa5fe Bookstack: Fix Update function composer (#700)
c46f15c fix: note component in json-editor getting out of focus when typing and revert theme switch animation (#706)
3d38ad0 Fix bugs in Komga update (#717)
9443286 Update CHANGELOG.md (#718)
259203e Update frontend CI/CD workflow (#703)
a4803d1 Update CHANGELOG.md (#720)
59deaa0 Update CHANGELOG.md (#721)
be4e650 Fix Hoarder build failure by installing Chromium stable (#723)
e45aba8 Update CHANGELOG.md (#726)
52898b4 Zigbee2MQTT: Remove dev branch choice until v2.0.0 release (#702)

📊 Changes

341 files changed (+9813 additions, -11786 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/bug_report.yml (+49 -20)
📝 .github/pull_request_template.md (+28 -20)
📝 .github/workflows/changelog-pr.yml (+1 -0)
➖ .github/workflows/deploy-pages.yml (+0 -79)
➕ .github/workflows/frontend-cicd.yml (+78 -0)
➕ .github/workflows/shellcheck.yml (+25 -0)
📝 CHANGELOG.md (+275 -1)
➕ ct/2fauth.sh (+90 -0)
📝 ct/actualbudget.sh (+30 -54)
📝 ct/adguard.sh (+24 -48)
📝 ct/adventurelog.sh (+59 -83)
📝 ct/agentdvr.sh (+24 -48)
📝 ct/alpine-docker.sh (+12 -42)
📝 ct/alpine-grafana.sh (+12 -42)
📝 ct/alpine-nextcloud.sh (+12 -41)
📝 ct/alpine-vaultwarden.sh (+13 -43)
📝 ct/alpine-zigbee2mqtt.sh (+11 -41)
📝 ct/alpine.sh (+20 -50)
📝 ct/apache-cassandra.sh (+23 -48)
📝 ct/apache-couchdb.sh (+24 -50)

...and 80 more files

📄 Description

✍️ Description

Adds and additional input to the advanced settings flow that allows adding an SSH authorized key for the root user.

Related Discussion: #860

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

I came up with multiple ways to implement this, but ultimately decided to go for the most pragmatic one to get a feel first.
Other possible implementation I had in mind:

option to forward authorized_keys from the PVE host (multi select menu) to the newly created container / vm
use a "well-known" file location or environment variable to contain the SSH key to authorize

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1052 **Author:** [@dsiebel](https://github.com/dsiebel) **Created:** 12/27/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `ssh-authorized-key` --- ### 📝 Commits (10+) - [`e2aa5fe`](https://github.com/community-scripts/ProxmoxVE/commit/e2aa5fe6278342263089f6b96c33f720e7c6a92e) Bookstack: Fix Update function composer (#700) - [`c46f15c`](https://github.com/community-scripts/ProxmoxVE/commit/c46f15cdc102de4cf06e35f3116b05fc2364a6a6) fix: note component in json-editor getting out of focus when typing and revert theme switch animation (#706) - [`3d38ad0`](https://github.com/community-scripts/ProxmoxVE/commit/3d38ad0288c61a328bf4730706f2d3ea19ab2fb6) Fix bugs in Komga update (#717) - [`9443286`](https://github.com/community-scripts/ProxmoxVE/commit/944328625a3b5c00b6f97c0c19e56ed172bee8ef) Update CHANGELOG.md (#718) - [`259203e`](https://github.com/community-scripts/ProxmoxVE/commit/259203ee51b33866d54ca823ba6faef4e87ea514) Update frontend CI/CD workflow (#703) - [`a4803d1`](https://github.com/community-scripts/ProxmoxVE/commit/a4803d178d83f96566ae3e498ea031b49e7df4aa) Update CHANGELOG.md (#720) - [`59deaa0`](https://github.com/community-scripts/ProxmoxVE/commit/59deaa0a194dae99b433bbdbdc21bbee6365c4d0) Update CHANGELOG.md (#721) - [`be4e650`](https://github.com/community-scripts/ProxmoxVE/commit/be4e6503d7758d518fb1f99f2cf0f72de6405d7e) Fix Hoarder build failure by installing Chromium stable (#723) - [`e45aba8`](https://github.com/community-scripts/ProxmoxVE/commit/e45aba86bd0be6fa5963072aac083f54c2c4962c) Update CHANGELOG.md (#726) - [`52898b4`](https://github.com/community-scripts/ProxmoxVE/commit/52898b4edf2bfbc91248884256d10a47de93c627) Zigbee2MQTT: Remove dev branch choice until v2.0.0 release (#702) ### 📊 Changes **341 files changed** (+9813 additions, -11786 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/bug_report.yml` (+49 -20) 📝 `.github/pull_request_template.md` (+28 -20) 📝 `.github/workflows/changelog-pr.yml` (+1 -0) ➖ `.github/workflows/deploy-pages.yml` (+0 -79) ➕ `.github/workflows/frontend-cicd.yml` (+78 -0) ➕ `.github/workflows/shellcheck.yml` (+25 -0) 📝 `CHANGELOG.md` (+275 -1) ➕ `ct/2fauth.sh` (+90 -0) 📝 `ct/actualbudget.sh` (+30 -54) 📝 `ct/adguard.sh` (+24 -48) 📝 `ct/adventurelog.sh` (+59 -83) 📝 `ct/agentdvr.sh` (+24 -48) 📝 `ct/alpine-docker.sh` (+12 -42) 📝 `ct/alpine-grafana.sh` (+12 -42) 📝 `ct/alpine-nextcloud.sh` (+12 -41) 📝 `ct/alpine-vaultwarden.sh` (+13 -43) 📝 `ct/alpine-zigbee2mqtt.sh` (+11 -41) 📝 `ct/alpine.sh` (+20 -50) 📝 `ct/apache-cassandra.sh` (+23 -48) 📝 `ct/apache-couchdb.sh` (+24 -50) _...and 80 more files_ </details> ### 📄 Description ## ✍️ Description Adds and additional input to the advanced settings flow that allows adding an SSH authorized key for the root user. - Related Discussion: #860 --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [ ] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. I came up with multiple ways to implement this, but ultimately decided to go for the most pragmatic one to get a feel first. Other possible implementation I had in mind: - option to forward authorized_keys from the PVE host (multi select menu) to the newly created container / vm - use a "well-known" file location or environment variable to contain the SSH key to authorize --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:32:03 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:36 +03:00

[PR #2992] [MERGED] [core] update date in json #4079

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2992

No description provided.

Rows
Columns