[PR #476] [MERGED] Fix #362: auto-detect race, VM shell path, UI hints #472

New issue

Closed

opened 2026-02-26 12:41:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/476
Author: @michelroegl-brunner
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @michelroegl-brunner

Base: main ← Head: fix/362

📝 Commits (1)

b5c6bea Fix #362: auto-detect race, VM shell path, UI hints

📊 Changes

3 files changed (+38 additions, -23 deletions)

View changed files

📝 server.js (+15 -14)
📝 src/app/_components/InstalledScriptsTab.tsx (+21 -7)
📝 src/server/api/routers/installedScripts.ts (+2 -2)

📄 Description

Summary

Implements fixes for issue #362.

Changes

Auto-detect race: Defer Promise resolve in pct list / qm list so stdout is fully delivered before parsing (fixes LXCs on same node not detected).
VM Shell: Pass containerType from UI to backend; use qm terminal for VMs and pct enter for LXC (fixes "Configuration file .../lxc/... does not exist" for VMs).
UI hint: Tooltip on Shell for VMs + inline message (serial console, qm set <vmid> -serial0 socket, detach with Ctrl+O).
Auto-detect label: Rename to "Auto-Detect Containers & VMs" and update help text.

Fixes #362

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/476 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/362` --- ### 📝 Commits (1) - [`b5c6bea`](https://github.com/community-scripts/ProxmoxVE-Local/commit/b5c6beafff865a9bc469c85523f79d3860695a6f) Fix #362: auto-detect race, VM shell path, UI hints ### 📊 Changes **3 files changed** (+38 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `server.js` (+15 -14) 📝 `src/app/_components/InstalledScriptsTab.tsx` (+21 -7) 📝 `src/server/api/routers/installedScripts.ts` (+2 -2) </details> ### 📄 Description ## Summary Implements fixes for [issue #362](https://github.com/community-scripts/ProxmoxVE-Local/issues/362). ### Changes - **Auto-detect race**: Defer Promise resolve in `pct list` / `qm list` so stdout is fully delivered before parsing (fixes LXCs on same node not detected). - **VM Shell**: Pass `containerType` from UI to backend; use `qm terminal` for VMs and `pct enter` for LXC (fixes "Configuration file .../lxc/... does not exist" for VMs). - **UI hint**: Tooltip on Shell for VMs + inline message (serial console, `qm set <vmid> -serial0 socket`, detach with Ctrl+O). - **Auto-detect label**: Rename to "Auto-Detect Containers & VMs" and update help text. Fixes #362 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>