[PR #479] [MERGED] fix: use node-specific Proxmox config paths for VM vs LXC (fixes #464) #476

New issue

Closed

opened 2026-02-26 12:41:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/479
Author: @michelroegl-brunner
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @michelroegl-brunner

Base: main ← Head: fix/464

📝 Commits (1)

6d2df99 fix: use node-specific Proxmox config paths for VM vs LXC detection

📊 Changes

2 files changed (+62 additions, -54 deletions)

View changed files

📝 server.js (+4 -3)
📝 src/server/api/routers/installedScripts.ts (+58 -51)

📄 Description

Summary

Fixes destroying LXC containers on multi-node Proxmox clusters where VM vs LXC detection used symlink paths that resolve to the wrong node.

Changes

isVM(): Check node-specific paths /etc/pve/nodes/<server.name>/qemu-server and lxc first; fall back to /etc/pve/qemu-server and /etc/pve/lxc for single-node setups.
checkConfigAndExtractInfo, config-existence checks (cleanupOrphanedScripts), getContainerHostname, addClonedContainerToDatabase: Use node-specific paths.
syncLXCConfig / updateLXCConfig: Use node-specific LXC config path.
server.js clone flow: Use node-specific config path when reading hostname/name.

Issue

Closes #464 — Destroying container was failing with Configuration file 'nodes/HP/qemu-server/168.conf' does not exist because the container is LXC (config at nodes/HP/lxc/168.conf); the app was incorrectly running qm destroy instead of pct destroy due to wrong-node path checks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/479 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/464` --- ### 📝 Commits (1) - [`6d2df99`](https://github.com/community-scripts/ProxmoxVE-Local/commit/6d2df9929c21bd3ce7dc4bec9ec2dd3c37994770) fix: use node-specific Proxmox config paths for VM vs LXC detection ### 📊 Changes **2 files changed** (+62 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `server.js` (+4 -3) 📝 `src/server/api/routers/installedScripts.ts` (+58 -51) </details> ### 📄 Description ## Summary Fixes destroying LXC containers on multi-node Proxmox clusters where VM vs LXC detection used symlink paths that resolve to the wrong node. ## Changes - **isVM()**: Check node-specific paths `/etc/pve/nodes/<server.name>/qemu-server` and `lxc` first; fall back to `/etc/pve/qemu-server` and `/etc/pve/lxc` for single-node setups. - **checkConfigAndExtractInfo**, config-existence checks (cleanupOrphanedScripts), **getContainerHostname**, **addClonedContainerToDatabase**: Use node-specific paths. - **syncLXCConfig** / **updateLXCConfig**: Use node-specific LXC config path. - **server.js** clone flow: Use node-specific config path when reading hostname/name. ## Issue Closes #464 — Destroying container was failing with `Configuration file 'nodes/HP/qemu-server/168.conf' does not exist` because the container is LXC (config at `nodes/HP/lxc/168.conf`); the app was incorrectly running `qm destroy` instead of `pct destroy` due to wrong-node path checks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>