[PR #86] [MERGED] Fix terminal colors and functionality issues #203

New issue

Closed

opened 2026-02-26 12:40:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:40:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/86
Author: @michelroegl-brunner
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/terminal_colors

📝 Commits (3)

6cd94c2 Fix terminal colors and stop button functionality
6e435c4 Fix downloaded scripts terminal functionality
d5aac7a Improve mobile terminal focus behavior

📊 Changes

7 files changed (+167 additions, -44 deletions)

View changed files

➕ scripts/ct/debian.sh (+43 -0)
➕ scripts/install/debian-install.sh (+24 -0)
📝 src/app/_components/DownloadedScriptsTab.tsx (+11 -4)
📝 src/app/_components/ScriptDetailModal.tsx (+0 -3)
📝 src/app/_components/Terminal.tsx (+50 -33)
📝 src/app/page.tsx (+19 -3)
📝 src/styles/globals.css (+20 -1)

📄 Description

Summary

This PR fixes several terminal-related issues that were affecting the user experience:

🎨 Terminal Color Fixes

Updated terminal theme to professional GitHub Dark theme
Fixed ANSI color handling without breaking script colors
Restored proper blue background and text colors
Fixed cursor rendering issues in whiptail sessions
Enhanced terminal styling with proper color palette configuration

🛑 Stop Button Functionality

Fixed stop button restarting script execution issue
Added proper state management to prevent auto-restart
Improved WebSocket connection stability
Prevented duplicate script executions
Fixed script restarting after ~1 second

🛠️ Downloaded Scripts Terminal Integration

Added install functionality to DownloadedScriptsTab component
Pass onInstallScript prop from main page to DownloadedScriptsTab
Enable terminal display when installing from downloaded scripts tab
Maintain consistency with available scripts tab functionality

🔧 Technical Improvements

Removed aggressive CSS overrides that were breaking ANSI color handling
Fixed WebSocket connection logic to prevent unnecessary reconnections
Added proper state tracking for script execution lifecycle
Improved terminal initialization and theme application

Testing

✅ Terminal colors display correctly on both mobile and desktop
✅ Stop button works without causing script restart
✅ Scripts start once without duplicate executions
✅ Downloaded scripts tab shows terminal when installing
✅ All terminal functionality works consistently across tabs

Files Changed

src/app/_components/Terminal.tsx - Terminal component improvements
src/styles/globals.css - Terminal styling fixes
src/app/page.tsx - Pass install handler to downloaded scripts
src/app/_components/DownloadedScriptsTab.tsx - Add install functionality

Fixes terminal color issues and missing terminal functionality for downloaded scripts.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/86 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/terminal_colors` --- ### 📝 Commits (3) - [`6cd94c2`](https://github.com/community-scripts/ProxmoxVE-Local/commit/6cd94c2c66ab6b0a09cd2a7dc6a86aa3107a9383) Fix terminal colors and stop button functionality - [`6e435c4`](https://github.com/community-scripts/ProxmoxVE-Local/commit/6e435c48a89b143fe3a2eb33243e16526663f3fa) Fix downloaded scripts terminal functionality - [`d5aac7a`](https://github.com/community-scripts/ProxmoxVE-Local/commit/d5aac7acffeba9a1437feeb29130961ac8d8190b) Improve mobile terminal focus behavior ### 📊 Changes **7 files changed** (+167 additions, -44 deletions) <details> <summary>View changed files</summary> ➕ `scripts/ct/debian.sh` (+43 -0) ➕ `scripts/install/debian-install.sh` (+24 -0) 📝 `src/app/_components/DownloadedScriptsTab.tsx` (+11 -4) 📝 `src/app/_components/ScriptDetailModal.tsx` (+0 -3) 📝 `src/app/_components/Terminal.tsx` (+50 -33) 📝 `src/app/page.tsx` (+19 -3) 📝 `src/styles/globals.css` (+20 -1) </details> ### 📄 Description ## Summary This PR fixes several terminal-related issues that were affecting the user experience: ### 🎨 Terminal Color Fixes - Updated terminal theme to professional GitHub Dark theme - Fixed ANSI color handling without breaking script colors - Restored proper blue background and text colors - Fixed cursor rendering issues in whiptail sessions - Enhanced terminal styling with proper color palette configuration ### 🛑 Stop Button Functionality - Fixed stop button restarting script execution issue - Added proper state management to prevent auto-restart - Improved WebSocket connection stability - Prevented duplicate script executions - Fixed script restarting after ~1 second ### 🛠️ Downloaded Scripts Terminal Integration - Added install functionality to DownloadedScriptsTab component - Pass onInstallScript prop from main page to DownloadedScriptsTab - Enable terminal display when installing from downloaded scripts tab - Maintain consistency with available scripts tab functionality ### 🔧 Technical Improvements - Removed aggressive CSS overrides that were breaking ANSI color handling - Fixed WebSocket connection logic to prevent unnecessary reconnections - Added proper state tracking for script execution lifecycle - Improved terminal initialization and theme application ## Testing - ✅ Terminal colors display correctly on both mobile and desktop - ✅ Stop button works without causing script restart - ✅ Scripts start once without duplicate executions - ✅ Downloaded scripts tab shows terminal when installing - ✅ All terminal functionality works consistently across tabs ## Files Changed - `src/app/_components/Terminal.tsx` - Terminal component improvements - `src/styles/globals.css` - Terminal styling fixes - `src/app/page.tsx` - Pass install handler to downloaded scripts - `src/app/_components/DownloadedScriptsTab.tsx` - Add install functionality Fixes terminal color issues and missing terminal functionality for downloaded scripts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>