[PR #24] [MERGED] Critical bug fixes for bulk operations and performance optimizations

## 📋 Pull Request Information **Original PR:** https://github.com/coelacant1/ProxmoxScripts/pull/24 **Author:** [@coelacant1](https://github.com/coelacant1) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@coelacant1](https://github.com/coelacant1) **Base:** `main` ← **Head:** `testing` --- ### 📝 Commits (2) - [`ab96daa`](https://github.com/coelacant1/ProxmoxScripts/commit/ab96daa8be765b97d2eb0e5ab9ee70a5d51f58f1) Bug fix for VerifySourceCalls.py validation tool - [`7fd8d5b`](https://github.com/coelacant1/ProxmoxScripts/commit/7fd8d5bd68b5c01fe4e4377e753d85b71222d19b) V2.1.8 - Critical bug fixes for bulk operations and performance optimizations ### 📊 Changes **18 files changed** (+1286 additions, -251 deletions) <details> <summary>View changed files</summary> 📝 `.check/VerifySourceCalls.py` (+34 -11) 📝 `.check/_RunChecks.sh` (+2 -2) 📝 `.gitignore` (+4 -0) 📝 `CHANGELOG.md` (+54 -1) 📝 `GUI.sh` (+93 -0) ➕ `Manuals/ssh-proxy-configuration.txt` (+278 -0) ➕ `Networking/FindVMIDFromIP.sh` (+349 -0) 📝 `Resources/ExportProxmoxResources.sh` (+4 -4) 📝 `Utilities/BulkOperations.sh` (+45 -12) 📝 `Utilities/Cluster.sh` (+10 -9) 📝 `Utilities/ConfigManager.sh` (+30 -8) 📝 `Utilities/Logger.sh` (+21 -7) 📝 `Utilities/Operations.sh` (+166 -87) 📝 `Utilities/RemoteExecutor.sh` (+124 -84) 📝 `Utilities/_Utilities.md` (+50 -17) 📝 `VirtualMachines/Operations/BulkCloneSetIP_Windows.sh` (+4 -2) 📝 `VirtualMachines/Operations/BulkDelete.sh` (+16 -7) 📝 `nodes.json.template` (+2 -0) </details> ### 📄 Description --- name: Critical bug fix for bulk operation scripts (mostly VM) about: Critical bug fixes for bulk operations and performance optimizations title: "[PR] Critical bug fixes for bulk operations and performance optimizations" labels: bug assignees: 'coelacant1' --- ## Description ### Fixed - **CRITICAL** - Fixed Bash dynamic scoping bug causing infinite recursion in bulk operations - **CRITICAL** - Fixed potential infinite polling in status wait functions - Fixed wasteful waiting when VM stop fails - Fixed temp file naming conflict in GUI.sh sessions - Added support for custom SSH ports - Fixed random node ordering in GUI - Cleaned up error handling in RemoteExecutor - Fixed TRACE logs appearing when LOG_LEVEL=INFO ### Changed - Reduced redundant queries in bulk operations - Added comprehensive logging to bulk operations framework ### Added - Added connection testing before script execution ## Type of Change - [X] Bug fix (non-breaking change fixing an issue) - [X] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature that would break existing functionality) - [X] Documentation update - [ ] Other (please describe): ## How Has This Been Tested? Tested across ~10 nodes on a 20 node cluster, performing various bulk vm scripts. ## Checklist - [X] I have performed a self-review of my own code. - [X] I have commented my code where necessary. - [X] I have made corresponding changes to the documentation (if applicable). - [X] My changes do not generate new warnings or errors. - [X] I have tested this code. ## Related Issues https://github.com/coelacant1/ProxmoxScripts/issues/23 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem commented

2026-03-03 01:17:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/coelacant1/ProxmoxScripts/pull/24
Author: @coelacant1
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @coelacant1

Base: main ← Head: testing

📝 Commits (2)

ab96daa Bug fix for VerifySourceCalls.py validation tool
7fd8d5b V2.1.8 - Critical bug fixes for bulk operations and performance optimizations

📊 Changes

18 files changed (+1286 additions, -251 deletions)

View changed files

📝 .check/VerifySourceCalls.py (+34 -11)
📝 .check/_RunChecks.sh (+2 -2)
📝 .gitignore (+4 -0)
📝 CHANGELOG.md (+54 -1)
📝 GUI.sh (+93 -0)
➕ Manuals/ssh-proxy-configuration.txt (+278 -0)
➕ Networking/FindVMIDFromIP.sh (+349 -0)
📝 Resources/ExportProxmoxResources.sh (+4 -4)
📝 Utilities/BulkOperations.sh (+45 -12)
📝 Utilities/Cluster.sh (+10 -9)
📝 Utilities/ConfigManager.sh (+30 -8)
📝 Utilities/Logger.sh (+21 -7)
📝 Utilities/Operations.sh (+166 -87)
📝 Utilities/RemoteExecutor.sh (+124 -84)
📝 Utilities/_Utilities.md (+50 -17)
📝 VirtualMachines/Operations/BulkCloneSetIP_Windows.sh (+4 -2)
📝 VirtualMachines/Operations/BulkDelete.sh (+16 -7)
📝 nodes.json.template (+2 -0)

📄 Description

name: Critical bug fix for bulk operation scripts (mostly VM)
about: Critical bug fixes for bulk operations and performance optimizations
title: "[PR] Critical bug fixes for bulk operations and performance optimizations"
labels: bug
assignees: 'coelacant1'

Description

Fixed

CRITICAL - Fixed Bash dynamic scoping bug causing infinite recursion in bulk operations
CRITICAL - Fixed potential infinite polling in status wait functions
Fixed wasteful waiting when VM stop fails
Fixed temp file naming conflict in GUI.sh sessions
Added support for custom SSH ports
Fixed random node ordering in GUI
Cleaned up error handling in RemoteExecutor
Fixed TRACE logs appearing when LOG_LEVEL=INFO

Changed

Reduced redundant queries in bulk operations
Added comprehensive logging to bulk operations framework

Added

Added connection testing before script execution

Type of Change

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature that would break existing functionality)
Documentation update
Other (please describe):

How Has This Been Tested?

Tested across ~10 nodes on a 20 node cluster, performing various bulk vm scripts.

Checklist

I have performed a self-review of my own code.
I have commented my code where necessary.
I have made corresponding changes to the documentation (if applicable).
My changes do not generate new warnings or errors.
I have tested this code.

https://github.com/coelacant1/ProxmoxScripts/issues/23

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem

closed this issue
added the
pull-request
label

Rows
Columns

[PR #24] [MERGED] Critical bug fixes for bulk operations and performance optimizations #24