starred/ProxmoxScripts

Fork

You've already forked ProxmoxScripts

mirror of https://github.com/coelacant1/ProxmoxScripts.git synced 2026-04-26 17:35:49 +03:00

Code Issues 6 Projects Releases 5 Packages Wiki Activity

[PR #21] [MERGED] V2.1.6 - Bug fixes, username support, and validation improvements #21

New issue

Closed

opened 2026-03-03 01:17:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:17:25 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/coelacant1/ProxmoxScripts/pull/21
Author: @coelacant1
Created: 11/25/2025
Status: ✅ Merged
Merged: 11/25/2025
Merged by: @coelacant1

Base: main ← Head: testing

📝 Commits (1)

d36fbc4 V2.1.6 - Bug fixes, username support, and validation improvements

📊 Changes

13 files changed (+356 additions, -91 deletions)

View changed files

📝 .check/VerifySourceCalls.py (+33 -13)
📝 .check/_RunChecks.sh (+27 -0)
📝 .gitignore (+1 -0)
➕ .site/MultiView.png (+0 -0)
➕ .site/MultiView2.png (+0 -0)
📝 CHANGELOG.md (+62 -0)
📝 GUI.sh (+146 -22)
📝 Host/HostInfo.sh (+0 -3)
📝 README.md (+9 -5)
📝 Utilities/ConfigManager.sh (+25 -7)
📝 Utilities/RemoteExecutor.sh (+45 -36)
📝 Utilities/_Utilities.md (+6 -5)
📝 nodes.json.template (+2 -0)

📄 Description

name: Bug fixes, username support, and validation improvements
about: Bug fixes, username support, and validation improvements
title: "[PR] Bug fixes, username support, and validation improvements"
labels: enhancement, bug
assignees: 'Coela'

Added

Username Configuration - Support for specifying SSH usernames per node
- Added username field to nodes.json configuration
- Username prompts in all node configuration flows (manual entry, saved nodes, IP ranges, VMID ranges)
- Default username is "root" with option to specify alternatives
- Display format changed to username@ip throughout GUI
Dependency Checking - Runtime validation before remote execution
- __check_remote_dependencies__() function checks for sshpass and jq
- Helpful error messages with installation commands for all major distros
- Notes that sshpass is not required when using SSH keys
Syntax Validation - Basic shell syntax checking added to validation suite
- New Check 1a. in _RunChecks.sh runs bash -n on all .sh files
- Catches structural errors and orphaned code blocks
- Shows file names and line numbers for syntax errors
Enhanced Source Verification - Improved validation of shellcheck directives
- VerifySourceCalls.py now validates shellcheck comments have matching source statements
- Detects orphaned shellcheck directives within 5 lines
- Prevents mismatched documentation and code

Changed

Remote Execution UI - Scripts hidden in remote mode for better UX
- GUI.sh and CCPVE.sh hidden from root menu when in remote execution mode
- Prevents accidental execution of control scripts on remote nodes
- Scripts still shown in local mode and subdirectories
README.md - Clarified dependency requirements
- Updated installation command to include jq and sshpass
- Documented that sshpass is only needed for password-based authentication
- Separated build-time tools from runtime dependencies

Fixed

Critical: Orphaned Error Handler - Fixed syntax error in Host/HostInfo.sh
- Removed orphaned error handler code block (lines 34-36)
- File had error message without matching source statement
- Bug prevented script execution on remote nodes
Username Hardcoding - Removed hardcoded "root@" from all remote operations
- Updated all SSH/SCP operations in RemoteExecutor.sh to use configured username
- __ssh_exec__, __scp_exec__, __scp_exec_recursive__, __scp_download__ now accept username parameter
- ConfigManager.sh tracks username per node in NODE_USERNAMES associative array
Missing Validation - Syntax check gap closed
- _RunChecks.sh never validated basic syntax :C
- Now catches structural errors that bash -n would detect
- Prevents orphaned code and malformed control structures from entering repository

Technical Details

nodes.json.template - Added username field with "root" default
Utilities/ConfigManager.sh - Added NODE_USERNAMES tracking and get_node_username() function
Utilities/RemoteExecutor.sh - All remote operations parameterized with username
GUI.sh - Dependency checking, username prompts, and script filtering
.check/VerifySourceCalls.py - Enhanced shellcheck directive validation
.check/_RunChecks.sh - Added Check 1a. for syntax validation

Developer Notes

The orphaned error handler bug existed because:

bash -n syntax check was not being run in validation suite
DeadCodeCheck.py only checks unused functions/variables, not code structure
VerifySourceCalls.py didn't validate orphaned error handlers The fix adds syntax validation to prevent similar issues...

Type of Change

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature that would break existing functionality)
Documentation update
Other (please describe):

How Has This Been Tested?

Validated all _RunChecks.

Checklist

I have performed a self-review of my own code.
I have commented my code where necessary.
I have made corresponding changes to the documentation (if applicable).
My changes do not generate new warnings or errors.
I have tested this code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/coelacant1/ProxmoxScripts/pull/21 **Author:** [@coelacant1](https://github.com/coelacant1) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 11/25/2025 **Merged by:** [@coelacant1](https://github.com/coelacant1) **Base:** `main` ← **Head:** `testing` --- ### 📝 Commits (1) - [`d36fbc4`](https://github.com/coelacant1/ProxmoxScripts/commit/d36fbc4a4d126fb2bdc2e55365ef3112397d18bc) V2.1.6 - Bug fixes, username support, and validation improvements ### 📊 Changes **13 files changed** (+356 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `.check/VerifySourceCalls.py` (+33 -13) 📝 `.check/_RunChecks.sh` (+27 -0) 📝 `.gitignore` (+1 -0) ➕ `.site/MultiView.png` (+0 -0) ➕ `.site/MultiView2.png` (+0 -0) 📝 `CHANGELOG.md` (+62 -0) 📝 `GUI.sh` (+146 -22) 📝 `Host/HostInfo.sh` (+0 -3) 📝 `README.md` (+9 -5) 📝 `Utilities/ConfigManager.sh` (+25 -7) 📝 `Utilities/RemoteExecutor.sh` (+45 -36) 📝 `Utilities/_Utilities.md` (+6 -5) 📝 `nodes.json.template` (+2 -0) </details> ### 📄 Description --- name: Bug fixes, username support, and validation improvements about: Bug fixes, username support, and validation improvements title: "[PR] Bug fixes, username support, and validation improvements" labels: enhancement, bug assignees: 'Coela' --- ### Added - **Username Configuration** - Support for specifying SSH usernames per node - Added `username` field to nodes.json configuration - Username prompts in all node configuration flows (manual entry, saved nodes, IP ranges, VMID ranges) - Default username is "root" with option to specify alternatives - Display format changed to `username@ip` throughout GUI - **Dependency Checking** - Runtime validation before remote execution - `__check_remote_dependencies__()` function checks for sshpass and jq - Helpful error messages with installation commands for all major distros - Notes that sshpass is not required when using SSH keys - **Syntax Validation** - Basic shell syntax checking added to validation suite - New Check 1a. in `_RunChecks.sh` runs `bash -n` on all .sh files - Catches structural errors and orphaned code blocks - Shows file names and line numbers for syntax errors - **Enhanced Source Verification** - Improved validation of shellcheck directives - `VerifySourceCalls.py` now validates shellcheck comments have matching source statements - Detects orphaned shellcheck directives within 5 lines - Prevents mismatched documentation and code ### Changed - **Remote Execution UI** - Scripts hidden in remote mode for better UX - GUI.sh and CCPVE.sh hidden from root menu when in remote execution mode - Prevents accidental execution of control scripts on remote nodes - Scripts still shown in local mode and subdirectories - **README.md** - Clarified dependency requirements - Updated installation command to include `jq` and `sshpass` - Documented that sshpass is only needed for password-based authentication - Separated build-time tools from runtime dependencies ### Fixed - **Critical: Orphaned Error Handler** - Fixed syntax error in `Host/HostInfo.sh` - Removed orphaned error handler code block (lines 34-36) - File had error message without matching source statement - Bug prevented script execution on remote nodes - **Username Hardcoding** - Removed hardcoded "root@" from all remote operations - Updated all SSH/SCP operations in `RemoteExecutor.sh` to use configured username - `__ssh_exec__`, `__scp_exec__`, `__scp_exec_recursive__`, `__scp_download__` now accept username parameter - `ConfigManager.sh` tracks username per node in `NODE_USERNAMES` associative array - **Missing Validation** - Syntax check gap closed - `_RunChecks.sh` never validated basic syntax :C - Now catches structural errors that bash -n would detect - Prevents orphaned code and malformed control structures from entering repository ### Technical Details - `nodes.json.template` - Added username field with "root" default - `Utilities/ConfigManager.sh` - Added NODE_USERNAMES tracking and __get_node_username__() function - `Utilities/RemoteExecutor.sh` - All remote operations parameterized with username - `GUI.sh` - Dependency checking, username prompts, and script filtering - `.check/VerifySourceCalls.py` - Enhanced shellcheck directive validation - `.check/_RunChecks.sh` - Added Check 1a. for syntax validation ### Developer Notes The orphaned error handler bug existed because: - `bash -n` syntax check was not being run in validation suite - `DeadCodeCheck.py` only checks unused functions/variables, not code structure - `VerifySourceCalls.py` didn't validate orphaned error handlers The fix adds syntax validation to prevent similar issues... ## Type of Change - [x] Bug fix (non-breaking change fixing an issue) - [x] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature that would break existing functionality) - [ ] Documentation update - [ ] Other (please describe): ## How Has This Been Tested? Validated all _RunChecks. ## Checklist - [x] I have performed a self-review of my own code. - [x] I have commented my code where necessary. - [x] I have made corresponding changes to the documentation (if applicable). - [x] My changes do not generate new warnings or errors. - [x] I have tested this code. ## Related Issues https://github.com/coelacant1/ProxmoxScripts/issues/20#issue-3662966025 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-03 01:17:25 +03:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

testing

v2.2.0

v2.1.9

v2.1.6

v2.1.4

v1.52

v1.51

v1.50

v1.49

v1.48

v1.47

v1.46

v1.45

v1.44

v1.43

v1.42

v1.41

v1.40

v1.39

v1.38

v1.37

v1.36

v1.35

v1.34

v1.33

v1.32

v1.31

v1.30

v1.29

v1.28

v1.27

v1.26

v1.25

v1.24

v1.23

v1.22

v1.21

v1.20

v1.19

v1.18

v1.17

v1.16

v1.15

v1.14

v1.13

v1.12

v1.11

v1.10

v1.9

v1.8

v1.7

v1.6

v1.5

v1.4

v1.3

v1.1

Labels

Clear labels

bug

enhancement

pull-request

Mirrored from GitHub Pull Request

No labels

bug

enhancement

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxScripts#21

Reference in a new issue

Repository

starred/ProxmoxScripts

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns