[PR #1567] [MERGED] feat!: multi-keymap #1885

Closed
opened 2026-03-03 19:09:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1567
Author: @TheMoonThatRises
Created: 7/7/2024
Status: Merged
Merged: 7/13/2025
Merged by: @JoseMoreville

Base: developHead: feat/multi-keymap


📝 Commits (10+)

  • 9f7b806 feat: mostly complete multi keymap
  • 8aff571 Merge branch 'PlayCover:develop' into feat/multi-keymap
  • edba5f4 Merge branch 'develop' into feat/multi-keymap
  • c0f469f Merge branch 'PlayCover:develop' into feat/multi-keymap
  • 29b0a6b fix versioning
  • b089f39 fix update changes
  • 3445b83 update config scheme
  • d54aa74 Merge branch 'PlayCover:develop' into feat/multi-keymap
  • ac84d2d add KeymapView view model
  • ccd0c08 add remaining localisations

📊 Changes

13 files changed (+675 additions, -101 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+8 -0)
📝 PlayCover/Model/Keymapping.swift (+155 -19)
PlayCover/Utils/UpdateScheme.swift (+91 -0)
📝 PlayCover/ViewModel/AppsVM.swift (+0 -43)
PlayCover/ViewModel/KeymapViewVM.swift (+44 -0)
📝 PlayCover/ViewModel/PlayAppVM.swift (+1 -0)
📝 PlayCover/Views/App Views/PlayAppView.swift (+7 -24)
📝 PlayCover/Views/AppSettingsView.swift (+4 -9)
PlayCover/Views/KeymapView.swift (+330 -0)
📝 PlayCover/Views/PlayCoverApp.swift (+2 -0)
📝 PlayCover/Views/Sidebar Views/AppLibraryView.swift (+7 -1)
📝 PlayCover/Views/Uninstaller.swift (+1 -1)
📝 PlayCover/en.lproj/Localizable.strings (+25 -4)

📄 Description

This pull request allows for each application to have multiple stored keymaps, with a separate UI for displaying the keymaps in settings. Note: This is still a work in progress, and the PlayTools side has not been worked on yet.

On completion, it should have these features:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1567 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 7/7/2024 **Status:** ✅ Merged **Merged:** 7/13/2025 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `feat/multi-keymap` --- ### 📝 Commits (10+) - [`9f7b806`](https://github.com/PlayCover/PlayCover/commit/9f7b806573451d8058b24f2790f11b4c694ca67d) feat: mostly complete multi keymap - [`8aff571`](https://github.com/PlayCover/PlayCover/commit/8aff571d301caf7486a503770a4e1bdbeaa667da) Merge branch 'PlayCover:develop' into feat/multi-keymap - [`edba5f4`](https://github.com/PlayCover/PlayCover/commit/edba5f4b0903cb4cd5e71354473061176126858d) Merge branch 'develop' into feat/multi-keymap - [`c0f469f`](https://github.com/PlayCover/PlayCover/commit/c0f469f19baa5287bea8545f5a55ee3d184410f0) Merge branch 'PlayCover:develop' into feat/multi-keymap - [`29b0a6b`](https://github.com/PlayCover/PlayCover/commit/29b0a6b5e6e04be6c9eecbf6abad9b086220a8a8) fix versioning - [`b089f39`](https://github.com/PlayCover/PlayCover/commit/b089f398b80f9fe597883b14bcd992c39442ef10) fix update changes - [`3445b83`](https://github.com/PlayCover/PlayCover/commit/3445b83fa0f4ff8fa2e869150767ef606a12ba6a) update config scheme - [`d54aa74`](https://github.com/PlayCover/PlayCover/commit/d54aa7452917e97f884d3614a437348a2e2ec19b) Merge branch 'PlayCover:develop' into feat/multi-keymap - [`ac84d2d`](https://github.com/PlayCover/PlayCover/commit/ac84d2d505eed8d653a89bd68da6cbb0de4189dc) add `KeymapView` view model - [`ccd0c08`](https://github.com/PlayCover/PlayCover/commit/ccd0c08e265c428e33b1b1c0aa6e00ea568e00a0) add remaining localisations ### 📊 Changes **13 files changed** (+675 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+8 -0) 📝 `PlayCover/Model/Keymapping.swift` (+155 -19) ➕ `PlayCover/Utils/UpdateScheme.swift` (+91 -0) 📝 `PlayCover/ViewModel/AppsVM.swift` (+0 -43) ➕ `PlayCover/ViewModel/KeymapViewVM.swift` (+44 -0) 📝 `PlayCover/ViewModel/PlayAppVM.swift` (+1 -0) 📝 `PlayCover/Views/App Views/PlayAppView.swift` (+7 -24) 📝 `PlayCover/Views/AppSettingsView.swift` (+4 -9) ➕ `PlayCover/Views/KeymapView.swift` (+330 -0) 📝 `PlayCover/Views/PlayCoverApp.swift` (+2 -0) 📝 `PlayCover/Views/Sidebar Views/AppLibraryView.swift` (+7 -1) 📝 `PlayCover/Views/Uninstaller.swift` (+1 -1) 📝 `PlayCover/en.lproj/Localizable.strings` (+25 -4) </details> ### 📄 Description This pull request allows for each application to have multiple stored keymaps, with a separate UI for displaying the keymaps in settings. **Note: This is still a work in progress, and the PlayTools side has not been worked on yet.** On completion, it should have these features: - Ability to have multiple keymaps and switch them in-game (https://github.com/PlayCover/PlayTools/issues/158 and https://github.com/PlayCover/PlayTools/issues/72) - ~~Scalable keymaps depending on aspect ratio (https://github.com/PlayCover/PlayTools/issues/155)~~ (I believe this feature should be contained within a separate pull request.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:09:29 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1885
No description provided.