[PR #308] [MERGED] Fix no app icon for some app #1567

New issue

Closed

opened 2026-03-03 19:07:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/308
Author: @KhoraLee
Created: 9/6/2022
Status: ✅ Merged
Merged: 9/7/2022
Merged by: @JoseMoreville

Base: develop ← Head: fix/appIcon

📝 Commits (2)

e422f9d feat: Extract app icon from assets.car
64fa7d6 fix: Load icon also from assets.car to fix no icon

📊 Changes

5 files changed (+137 additions, -14 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+14 -0)
📝 PlayCover/Model/PlayApp.swift (+25 -14)
📝 PlayCover/PlayCover-Bridging-Header.h (+1 -0)
➕ PlayCover/Utils/AssetsExtractor.swift (+75 -0)
➕ PlayCover/Utils/CoreUI.h (+22 -0)

📄 Description

This PR will extract app icon's also from Assets.car and select highest resolution icon.

Still apps that doesn't have app icon will show spinning progress circle.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/308 **Author:** [@KhoraLee](https://github.com/KhoraLee) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 9/7/2022 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `fix/appIcon` --- ### 📝 Commits (2) - [`e422f9d`](https://github.com/PlayCover/PlayCover/commit/e422f9da1422e437de62471f3994308ed062ae04) feat: Extract app icon from assets.car - [`64fa7d6`](https://github.com/PlayCover/PlayCover/commit/64fa7d65d1a26ca008640586e118a9552247553d) fix: Load icon also from assets.car to fix no icon ### 📊 Changes **5 files changed** (+137 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+14 -0) 📝 `PlayCover/Model/PlayApp.swift` (+25 -14) 📝 `PlayCover/PlayCover-Bridging-Header.h` (+1 -0) ➕ `PlayCover/Utils/AssetsExtractor.swift` (+75 -0) ➕ `PlayCover/Utils/CoreUI.h` (+22 -0) </details> ### 📄 Description This PR will extract app icon's also from `Assets.car` and select highest resolution icon. Still apps that doesn't have app icon will show spinning progress circle. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>