[PR #1130] [MERGED] Fix Discord RPC #1818

New issue

Closed

opened 2026-03-03 19:09:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1130
Author: @TheMoonThatRises
Created: 10/8/2023
Status: ✅ Merged
Merged: 11/2/2023
Merged by: @JoseMoreville

Base: develop ← Head: fix/swordrpc

📝 Commits (2)

7b7b3a2 fix: discord rpc
1e8e74c fix error when container does not exist

📊 Changes

11 files changed (+123 additions, -80 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/AppInstaller/Installer.swift (+3 -3)
📝 PlayCover/Model/AppContainer.swift (+14 -27)
📝 PlayCover/Model/AppSettings.swift (+1 -3)
📝 PlayCover/Model/Keymapping.swift (+1 -3)
📝 PlayCover/Model/PlayApp.swift (+9 -9)
📝 PlayCover/Utils/Cacher.swift (+4 -8)
➕ PlayCover/Utils/Extensions/PlayAppExtensions.swift (+49 -0)
📝 PlayCover/Utils/Extensions/URLExtensions.swift (+23 -5)
📝 PlayCover/ViewModel/AppsVM.swift (+2 -5)
📝 PlayCover/Views/Uninstaller.swift (+13 -17)

📄 Description

Fixes #1112 and requires https://github.com/PlayCover/PlayTools/pull/126, https://github.com/PlayCover/SwordRPC/pull/1. The fix is to symbolically link the discord-ipc socket "file" to the app's own temporary directory in ~/Library/Containers/[App ID]/Data/tmp at the initialisation of each app model. In order to accomplish this, some of the functions and models have been changed, such as the enumerate function in FileManager and the AppContainer model itself. Along with that, the PlayAppExtensions.swift file was created to avoid going over the line limit for PlayApp with SwiftLint.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1130 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 10/8/2023 **Status:** ✅ Merged **Merged:** 11/2/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `fix/swordrpc` --- ### 📝 Commits (2) - [`7b7b3a2`](https://github.com/PlayCover/PlayCover/commit/7b7b3a2d540952ebbc4d44be1334c7a052228878) fix: discord rpc - [`1e8e74c`](https://github.com/PlayCover/PlayCover/commit/1e8e74c6ed9146e349dd9af0a1685208f7d44b68) fix error when container does not exist ### 📊 Changes **11 files changed** (+123 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/AppInstaller/Installer.swift` (+3 -3) 📝 `PlayCover/Model/AppContainer.swift` (+14 -27) 📝 `PlayCover/Model/AppSettings.swift` (+1 -3) 📝 `PlayCover/Model/Keymapping.swift` (+1 -3) 📝 `PlayCover/Model/PlayApp.swift` (+9 -9) 📝 `PlayCover/Utils/Cacher.swift` (+4 -8) ➕ `PlayCover/Utils/Extensions/PlayAppExtensions.swift` (+49 -0) 📝 `PlayCover/Utils/Extensions/URLExtensions.swift` (+23 -5) 📝 `PlayCover/ViewModel/AppsVM.swift` (+2 -5) 📝 `PlayCover/Views/Uninstaller.swift` (+13 -17) </details> ### 📄 Description Fixes #1112 and requires https://github.com/PlayCover/PlayTools/pull/126, https://github.com/PlayCover/SwordRPC/pull/1. The fix is to symbolically link the discord-ipc socket "file" to the app's own temporary directory in `~/Library/Containers/[App ID]/Data/tmp` at the initialisation of each app model. In order to accomplish this, some of the functions and models have been changed, such as the `enumerate` function in FileManager and the `AppContainer` model itself. Along with that, the `PlayAppExtensions.swift` file was created to avoid going over the line limit for `PlayApp` with SwiftLint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>