[PR #1088] [MERGED] Fix MetalHUD not showing when launching app from alias #1811

New issue

Closed

opened 2026-03-03 19:09:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1088
Author: @TheMoonThatRises
Created: 9/8/2023
Status: ✅ Merged
Merged: 9/25/2023
Merged by: @JoseMoreville

Base: develop ← Head: fix/metalhud

📝 Commits (1)

c86f370 fix: metalhud not working when launch from alias

📊 Changes

3 files changed (+19 additions, -7 deletions)

View changed files

📝 PlayCover/Model/AppSettings.swift (+14 -1)
📝 PlayCover/Model/PlayApp.swift (+0 -6)
📝 PlayCover/Utils/Shell.swift (+5 -0)

📄 Description

Fixes #961. Writes to the defaults key MetalForceHudEnabled instead of saving as an environment variable.

Thoughts for reviewer:

Should MetalHud be removed from the settings file and have it directly linked to defaults (similar to PlayTools checking if it is installed in the binary instead of keeping track via the settings file)?
Should this be merged into #1090, with it being stored in the Info.plist instead of defaults?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1088 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 9/8/2023 **Status:** ✅ Merged **Merged:** 9/25/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `fix/metalhud` --- ### 📝 Commits (1) - [`c86f370`](https://github.com/PlayCover/PlayCover/commit/c86f370b0411fd8660c7fc64f6e3a68ed3dcba9c) fix: metalhud not working when launch from alias ### 📊 Changes **3 files changed** (+19 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppSettings.swift` (+14 -1) 📝 `PlayCover/Model/PlayApp.swift` (+0 -6) 📝 `PlayCover/Utils/Shell.swift` (+5 -0) </details> ### 📄 Description Fixes #961. Writes to the `defaults` key `MetalForceHudEnabled` instead of saving as an environment variable. Thoughts for reviewer: - Should MetalHud be removed from the settings file and have it directly linked to `defaults` (similar to PlayTools checking if it is installed in the binary instead of keeping track via the settings file)? - Should this be merged into #1090, with it being stored in the `Info.plist` instead of `defaults`? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>