[PR #1090] [MERGED] Fix environment variables when launching via alias #1810

New issue

Closed

opened 2026-03-03 19:09:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1090
Author: @TheMoonThatRises
Created: 9/9/2023
Status: ✅ Merged
Merged: 9/25/2023
Merged by: @JoseMoreville

Base: develop ← Head: fix/environment-variables

📝 Commits (3)

c86f370 fix: metalhud not working when launch from alias
b3830de fix: environment variables
93527ef Merge branch 'develop' into fix/environment-variables

📊 Changes

3 files changed (+63 additions, -2 deletions)

View changed files

📝 PlayCover/Model/AppInfo.swift (+25 -0)
📝 PlayCover/Model/PlayApp.swift (+27 -0)
📝 PlayCover/Views/AppSettingsView.swift (+11 -2)

📄 Description

Sets the environmental variables in the Info.plist file inside the app. Fixes #1012.

Requires #1088 to be merged or modified into this pull request.

Thoughts for reviewer:

The app is required to be codesigned after each change to the Info.plist, which may be slow for larger apps.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1090 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 9/9/2023 **Status:** ✅ Merged **Merged:** 9/25/2023 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `fix/environment-variables` --- ### 📝 Commits (3) - [`c86f370`](https://github.com/PlayCover/PlayCover/commit/c86f370b0411fd8660c7fc64f6e3a68ed3dcba9c) fix: metalhud not working when launch from alias - [`b3830de`](https://github.com/PlayCover/PlayCover/commit/b3830decc7b0c3803e560e38e9ae9f961d052fd4) fix: environment variables - [`93527ef`](https://github.com/PlayCover/PlayCover/commit/93527efe3255985d73054c5c7901a2d404244ea2) Merge branch 'develop' into fix/environment-variables ### 📊 Changes **3 files changed** (+63 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppInfo.swift` (+25 -0) 📝 `PlayCover/Model/PlayApp.swift` (+27 -0) 📝 `PlayCover/Views/AppSettingsView.swift` (+11 -2) </details> ### 📄 Description Sets the environmental variables in the `Info.plist` file inside the app. Fixes #1012. Requires #1088 to be merged or modified into this pull request. Thoughts for reviewer: - The app is required to be codesigned after each change to the `Info.plist`, which may be slow for larger apps. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>