[PR #839] [MERGED] HTTP code check #1769

Closed
opened 2026-03-03 19:08:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/839
Author: @TheMoonThatRises
Created: 3/5/2023
Status: Merged
Merged: 3/7/2023
Merged by: @Depal1

Base: developHead: feat/httpcodecheck


📝 Commits (3)

  • a797383 feat: IPA library http code check
  • d459f99 feat: less laggy IPA library loading images
  • c02b9d5 fix swiftlint

📊 Changes

6 files changed (+144 additions, -92 deletions)

View changed files

📝 PlayCover/AppInstaller/Downloader.swift (+1 -2)
📝 PlayCover/Model/ITunesResponse.swift (+18 -13)
📝 PlayCover/ViewModel/NetworkVM.swift (+39 -8)
📝 PlayCover/ViewModel/StoreVM.swift (+34 -47)
📝 PlayCover/Views/Settings/IPASourceSettings.swift (+51 -22)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)

📄 Description

Checks for HTTP status code when downloading apps from IPA library. Also improves lagginess of IPA library when first downloading all images, switching to URLSession.shared.dataTask instead of URLSession.shared.data.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/839 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 3/5/2023 **Status:** ✅ Merged **Merged:** 3/7/2023 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `feat/httpcodecheck` --- ### 📝 Commits (3) - [`a797383`](https://github.com/PlayCover/PlayCover/commit/a797383b3563b026b02873e4a5952a2748e58862) feat: IPA library http code check - [`d459f99`](https://github.com/PlayCover/PlayCover/commit/d459f99d531b231f74c3b0396d8b14d3aebe6e06) feat: less laggy IPA library loading images - [`c02b9d5`](https://github.com/PlayCover/PlayCover/commit/c02b9d5681ca3283045b24997191f2b91ea4e1d5) fix swiftlint ### 📊 Changes **6 files changed** (+144 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Downloader.swift` (+1 -2) 📝 `PlayCover/Model/ITunesResponse.swift` (+18 -13) 📝 `PlayCover/ViewModel/NetworkVM.swift` (+39 -8) 📝 `PlayCover/ViewModel/StoreVM.swift` (+34 -47) 📝 `PlayCover/Views/Settings/IPASourceSettings.swift` (+51 -22) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description Checks for HTTP status code when downloading apps from IPA library. Also improves lagginess of IPA library when first downloading all images, switching to `URLSession.shared.dataTask` instead of `URLSession.shared.data`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:08:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1769
No description provided.