[PR #453] [MERGED] Improve PlayTools installer interactions #1626

New issue

Closed

opened 2026-03-03 19:08:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:08:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/453
Author: @TheMoonThatRises
Created: 10/26/2022
Status: ✅ Merged
Merged: 11/2/2022
Merged by: @Depal1

Base: develop ← Head: fix/playtoolsinstallclarity

📝 Commits (10+)

af32b68 fix: make install playtools clearer
bc1fb8d feat: change PlayTools installation behavior (#1)
feedbbe simplify if-statement + swiftlint
d97d7c3 fix trailing whitespace
85dacfc clarify PlayTools make break certain apps
4de07c1 fix AKInterface installing despite no PlayTools
cb87478 allow user to cancel install with popup
87ffab0 make install preferences consistent with uninstall
f780062 remove PlugIn directory if it is empty
486c09d Update PlayCover/en.lproj/Localizable.strings

📊 Changes

5 files changed (+114 additions, -72 deletions)

View changed files

📝 PlayCover/AppInstaller/Installer.swift (+80 -62)
📝 PlayCover/Model/PlayApp.swift (+6 -1)
📝 PlayCover/Utils/PlayTools.swift (+6 -3)
📝 PlayCover/Views/Settings/InstallSettings.swift (+20 -5)
📝 PlayCover/en.lproj/Localizable.strings (+2 -1)

📄 Description

Makes the PlayTools install popup clearer by including what it does, and not appear to the regular user

Make install popup not popup by default, and triggered by holding option key
Clarify what PlayTools does and not make the button destructive
Allow user to cancel installation process when using the install popup
Remove AKInterface if PlayTools is not installed to restore app to it's original state

Make install popup appear only when the user presses the option key while installing or configures it in settings
Improved install alert

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/453 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 10/26/2022 **Status:** ✅ Merged **Merged:** 11/2/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/playtoolsinstallclarity` --- ### 📝 Commits (10+) - [`af32b68`](https://github.com/PlayCover/PlayCover/commit/af32b68a43f7beb93233f489b8b65037077f17d1) fix: make install playtools clearer - [`bc1fb8d`](https://github.com/PlayCover/PlayCover/commit/bc1fb8d1c799636caa58cc42337c8b625bffe0d6) feat: change PlayTools installation behavior (#1) - [`feedbbe`](https://github.com/PlayCover/PlayCover/commit/feedbbe3ecc4e4fdba7b77f34b9ed73d62223b3c) simplify if-statement + swiftlint - [`d97d7c3`](https://github.com/PlayCover/PlayCover/commit/d97d7c3435e60af1c8224ab8a02697086b3c12c8) fix trailing whitespace - [`85dacfc`](https://github.com/PlayCover/PlayCover/commit/85dacfc97efb7bb1ba7ae4511bf396070bde3337) clarify PlayTools make break certain apps - [`4de07c1`](https://github.com/PlayCover/PlayCover/commit/4de07c103e43c3ecbe2af177cbb2cf5da4de328a) fix AKInterface installing despite no PlayTools - [`cb87478`](https://github.com/PlayCover/PlayCover/commit/cb874783581e58e81eef6b8b131d647eb30d6719) allow user to cancel install with popup - [`87ffab0`](https://github.com/PlayCover/PlayCover/commit/87ffab095f1561c38834fd725b33087c2c3c702c) make install preferences consistent with uninstall - [`f780062`](https://github.com/PlayCover/PlayCover/commit/f7800624739ddfece9aae2413e7e0f68269c2b01) remove PlugIn directory if it is empty - [`486c09d`](https://github.com/PlayCover/PlayCover/commit/486c09d103b1d601e8c24b750c2c6c641a8507ee) Update PlayCover/en.lproj/Localizable.strings ### 📊 Changes **5 files changed** (+114 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Installer.swift` (+80 -62) 📝 `PlayCover/Model/PlayApp.swift` (+6 -1) 📝 `PlayCover/Utils/PlayTools.swift` (+6 -3) 📝 `PlayCover/Views/Settings/InstallSettings.swift` (+20 -5) 📝 `PlayCover/en.lproj/Localizable.strings` (+2 -1) </details> ### 📄 Description Makes the PlayTools install popup clearer by including what it does, and not appear to the regular user * Make install popup not popup by default, and triggered by holding option key * Clarify what PlayTools does and not make the button destructive * Allow user to cancel installation process when using the install popup * Remove AKInterface if PlayTools is not installed to restore app to it's original state - [x] Make install popup appear only when the user presses the option key while installing or configures it in settings - [x] Improved install alert --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>