[PR #429] [CLOSED] SourceVM Backend #1611

New issue

Closed

opened 2026-03-03 19:07:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/429
Author: @IsaacMarovitz
Created: 10/19/2022
Status: ❌ Closed

Base: develop ← Head: keymap-download

📝 Commits (10+)

2e6c4eb Fix erroneous error log
6558228 swiftlint :/
0eceb52 Styling improvements + Removed NSHomeDirectory()
8003529 More cleanup
856110f URL Refactor
4a0646a More cleanup
316b25d Installer refactor
32eaacd Better error checking
453be27 Image Cache
81ab896 Fix AppSettings

📊 Changes

10 files changed (+266 additions, -257 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+16 -4)
➕ PlayCover/ViewModel/SourceVM/IPASourceVM.swift (+95 -0)
➕ PlayCover/ViewModel/SourceVM/SourceVM.swift (+118 -0)
➖ PlayCover/ViewModel/StoreVM.swift (+0 -190)
📝 PlayCover/Views/MainView.swift (+3 -3)
📝 PlayCover/Views/MenuBarView.swift (+1 -1)
📝 PlayCover/Views/PlayCoverApp.swift (+3 -3)
📝 PlayCover/Views/Settings/IPASourceSettings.swift (+22 -48)
📝 PlayCover/Views/Settings/PlayCoverSettingsView.swift (+2 -2)
📝 PlayCover/Views/Sidebar Views/IPALibraryView.swift (+6 -6)

📄 Description

A new implementation of #371, based on the #417 branch

Reasons for reimplementing:

Zhich's implementation suffers from a couple of structural problems that go counter to the existing source-based VM infrastructure
I initially attempted to add my fixes in a PR to Zhich's branch but I kept running into weird state issues, so in the end I felt that reimplementing would be easier, and reduce spaghetti

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/429 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 10/19/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `keymap-download` --- ### 📝 Commits (10+) - [`2e6c4eb`](https://github.com/PlayCover/PlayCover/commit/2e6c4ebd4cc1246078ca405099485644eb4e904d) Fix erroneous error log - [`6558228`](https://github.com/PlayCover/PlayCover/commit/655822867d3013cdbe82642c856fd3c8c3fc58b3) swiftlint :/ - [`0eceb52`](https://github.com/PlayCover/PlayCover/commit/0eceb527106e7d23278773810569e2b12033436c) Styling improvements + Removed NSHomeDirectory() - [`8003529`](https://github.com/PlayCover/PlayCover/commit/800352952e2df961a94932dfceecde502dba98b1) More cleanup - [`856110f`](https://github.com/PlayCover/PlayCover/commit/856110f4fb2468227a4fb908a59899e6c77386ae) URL Refactor - [`4a0646a`](https://github.com/PlayCover/PlayCover/commit/4a0646a48f5c045c24a8b5ed9d4a211d5f53a502) More cleanup - [`316b25d`](https://github.com/PlayCover/PlayCover/commit/316b25d08bc6776b3099df72413e12e51663d8b3) Installer refactor - [`32eaacd`](https://github.com/PlayCover/PlayCover/commit/32eaacddb91b697fae1b6e933501f87f5536a765) Better error checking - [`453be27`](https://github.com/PlayCover/PlayCover/commit/453be27325e44b41430f98a138d7a1ccd804011b) Image Cache - [`81ab896`](https://github.com/PlayCover/PlayCover/commit/81ab896243980f7ba92403ca3f41270f9f5f0bb4) Fix AppSettings ### 📊 Changes **10 files changed** (+266 additions, -257 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+16 -4) ➕ `PlayCover/ViewModel/SourceVM/IPASourceVM.swift` (+95 -0) ➕ `PlayCover/ViewModel/SourceVM/SourceVM.swift` (+118 -0) ➖ `PlayCover/ViewModel/StoreVM.swift` (+0 -190) 📝 `PlayCover/Views/MainView.swift` (+3 -3) 📝 `PlayCover/Views/MenuBarView.swift` (+1 -1) 📝 `PlayCover/Views/PlayCoverApp.swift` (+3 -3) 📝 `PlayCover/Views/Settings/IPASourceSettings.swift` (+22 -48) 📝 `PlayCover/Views/Settings/PlayCoverSettingsView.swift` (+2 -2) 📝 `PlayCover/Views/Sidebar Views/IPALibraryView.swift` (+6 -6) </details> ### 📄 Description A new implementation of #371, based on the #417 branch Reasons for reimplementing: - Zhich's implementation suffers from a couple of structural problems that go counter to the existing source-based VM infrastructure - I initially attempted to add my fixes in a PR to Zhich's branch but I kept running into weird state issues, so in the end I felt that reimplementing would be easier, and reduce spaghetti --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>