[PR #417] [MERGED] Code Cleanup + Styling Fixes + Image Cache #1607

New issue

Closed

opened 2026-03-03 19:07:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/417
Author: @IsaacMarovitz
Created: 10/12/2022
Status: ✅ Merged
Merged: 10/19/2022
Merged by: @Depal1

Base: develop ← Head: develop

📝 Commits (10+)

2e6c4eb Fix erroneous error log
6558228 swiftlint :/
0eceb52 Styling improvements + Removed NSHomeDirectory()
8003529 More cleanup
856110f URL Refactor
4a0646a More cleanup
316b25d Installer refactor
32eaacd Better error checking
453be27 Image Cache
81ab896 Fix AppSettings

📊 Changes

29 files changed (+676 additions, -491 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+19 -3)
📝 PlayCover/AppInstaller/Installer.swift (+31 -55)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+20 -10)
📝 PlayCover/IntentFlow/UserIntentFlow.swift (+0 -5)
📝 PlayCover/Model/AppContainer.swift (+2 -1)
📝 PlayCover/Model/AppInfo.swift (+21 -7)
📝 PlayCover/Model/BaseApp.swift (+5 -2)
📝 PlayCover/Model/PlayApp.swift (+0 -25)
📝 PlayCover/Utils/GenshinUserData/DeleteStoredGenshinUserData.swift (+4 -4)
➕ PlayCover/Utils/GenshinUserData/GenshinUserDataURLs.swift (+42 -0)
➕ PlayCover/Utils/GenshinUserData/RestoreGenshinUserData.swift (+103 -0)
➕ PlayCover/Utils/GenshinUserData/SaveGenshinUserData.swift (+96 -0)
➕ PlayCover/Utils/ImageCache.swift (+166 -0)
📝 PlayCover/Utils/LegacySettings.swift (+4 -2)
📝 PlayCover/Utils/PlayTools.swift (+2 -10)
➖ PlayCover/Utils/RestoreGenshinUserData.swift (+0 -104)
➖ PlayCover/Utils/SaveGenshinUserData.swift (+0 -105)
📝 PlayCover/Utils/Shell.swift (+0 -1)
📝 PlayCover/ViewModel/AppSettingsVM.swift (+0 -1)
📝 PlayCover/ViewModel/AppsVM.swift (+3 -2)

...and 9 more files

📄 Description

This PR fixes #362
This also fixes issues where Duolingo, Infinity Blade, and Netflix would show with the wrong/no icon

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/417 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 10/12/2022 **Status:** ✅ Merged **Merged:** 10/19/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`2e6c4eb`](https://github.com/PlayCover/PlayCover/commit/2e6c4ebd4cc1246078ca405099485644eb4e904d) Fix erroneous error log - [`6558228`](https://github.com/PlayCover/PlayCover/commit/655822867d3013cdbe82642c856fd3c8c3fc58b3) swiftlint :/ - [`0eceb52`](https://github.com/PlayCover/PlayCover/commit/0eceb527106e7d23278773810569e2b12033436c) Styling improvements + Removed NSHomeDirectory() - [`8003529`](https://github.com/PlayCover/PlayCover/commit/800352952e2df961a94932dfceecde502dba98b1) More cleanup - [`856110f`](https://github.com/PlayCover/PlayCover/commit/856110f4fb2468227a4fb908a59899e6c77386ae) URL Refactor - [`4a0646a`](https://github.com/PlayCover/PlayCover/commit/4a0646a48f5c045c24a8b5ed9d4a211d5f53a502) More cleanup - [`316b25d`](https://github.com/PlayCover/PlayCover/commit/316b25d08bc6776b3099df72413e12e51663d8b3) Installer refactor - [`32eaacd`](https://github.com/PlayCover/PlayCover/commit/32eaacddb91b697fae1b6e933501f87f5536a765) Better error checking - [`453be27`](https://github.com/PlayCover/PlayCover/commit/453be27325e44b41430f98a138d7a1ccd804011b) Image Cache - [`81ab896`](https://github.com/PlayCover/PlayCover/commit/81ab896243980f7ba92403ca3f41270f9f5f0bb4) Fix AppSettings ### 📊 Changes **29 files changed** (+676 additions, -491 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+19 -3) 📝 `PlayCover/AppInstaller/Installer.swift` (+31 -55) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+20 -10) 📝 `PlayCover/IntentFlow/UserIntentFlow.swift` (+0 -5) 📝 `PlayCover/Model/AppContainer.swift` (+2 -1) 📝 `PlayCover/Model/AppInfo.swift` (+21 -7) 📝 `PlayCover/Model/BaseApp.swift` (+5 -2) 📝 `PlayCover/Model/PlayApp.swift` (+0 -25) 📝 `PlayCover/Utils/GenshinUserData/DeleteStoredGenshinUserData.swift` (+4 -4) ➕ `PlayCover/Utils/GenshinUserData/GenshinUserDataURLs.swift` (+42 -0) ➕ `PlayCover/Utils/GenshinUserData/RestoreGenshinUserData.swift` (+103 -0) ➕ `PlayCover/Utils/GenshinUserData/SaveGenshinUserData.swift` (+96 -0) ➕ `PlayCover/Utils/ImageCache.swift` (+166 -0) 📝 `PlayCover/Utils/LegacySettings.swift` (+4 -2) 📝 `PlayCover/Utils/PlayTools.swift` (+2 -10) ➖ `PlayCover/Utils/RestoreGenshinUserData.swift` (+0 -104) ➖ `PlayCover/Utils/SaveGenshinUserData.swift` (+0 -105) 📝 `PlayCover/Utils/Shell.swift` (+0 -1) 📝 `PlayCover/ViewModel/AppSettingsVM.swift` (+0 -1) 📝 `PlayCover/ViewModel/AppsVM.swift` (+3 -2) _...and 9 more files_ </details> ### 📄 Description This PR fixes #362 This also fixes issues where Duolingo, Infinity Blade, and Netflix would show with the wrong/no icon --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>