[PR #320] [MERGED] feat: New App Signing configuration experience. #1574

Closed
opened 2026-03-03 19:07:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/320
Author: @ohaiibuzzle
Created: 9/8/2022
Status: Merged
Merged: 9/11/2022
Merged by: @Depal1

Base: developHead: feat/new-signing-experience


📝 Commits (4)

  • e8a79c1 fix!: Use the current system status to determine if PlaySign should be enabled
  • 90ca6df feat!: New app fake-signing setup experience
  • 3e21273 fix: add a PlayBook Button to the Configure Signing UI
  • 2b5801d feat: Add function description to the window

📊 Changes

6 files changed (+171 additions, -5 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/Utils/SystemConfig.swift (+9 -1)
📝 PlayCover/Views/MainView.swift (+7 -2)
📝 PlayCover/Views/MenuBarView.swift (+5 -0)
📝 PlayCover/Views/PlayCoverApp.swift (+4 -2)
PlayCover/Views/SigningSetupView.swift (+142 -0)

📄 Description

This commit brings a new, guided approach for configuring app signing (which make login in apps like Genshin works)

The "wizard" guides the user through disabling SIP and disabling AMFI in a more visual manner.

Here is what it looks like:
Menu accessible via PlayCover > Configure Signing:
image

AMFI:
out

Signing ready:
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/320 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 9/8/2022 **Status:** ✅ Merged **Merged:** 9/11/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `feat/new-signing-experience` --- ### 📝 Commits (4) - [`e8a79c1`](https://github.com/PlayCover/PlayCover/commit/e8a79c1cb8e8dfb06ebea68fe13a88042be8a330) fix!: Use the current system status to determine if PlaySign should be enabled - [`90ca6df`](https://github.com/PlayCover/PlayCover/commit/90ca6df517161cfe4e5fc62cd52ababa5a8abfb1) feat!: New app fake-signing setup experience - [`3e21273`](https://github.com/PlayCover/PlayCover/commit/3e212733488adbcd51cc6db3d514d23dc655800e) fix: add a PlayBook Button to the Configure Signing UI - [`2b5801d`](https://github.com/PlayCover/PlayCover/commit/2b5801d7a8f79dbcf5192e4eecbac2d05ddd38dd) feat: Add function description to the window ### 📊 Changes **6 files changed** (+171 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/Utils/SystemConfig.swift` (+9 -1) 📝 `PlayCover/Views/MainView.swift` (+7 -2) 📝 `PlayCover/Views/MenuBarView.swift` (+5 -0) 📝 `PlayCover/Views/PlayCoverApp.swift` (+4 -2) ➕ `PlayCover/Views/SigningSetupView.swift` (+142 -0) </details> ### 📄 Description This commit brings a new, guided approach for configuring app signing (which make login in apps like Genshin works) The "wizard" guides the user through disabling SIP and disabling AMFI in a more visual manner. Here is what it looks like: Menu accessible via PlayCover > Configure Signing: <img width="1012" alt="image" src="https://user-images.githubusercontent.com/23693150/189166113-353fc846-a74b-4d5d-9051-16074b34f296.png"> AMFI: ![out](https://user-images.githubusercontent.com/23693150/189166819-ab2b472a-ce55-4b0a-aac0-4871f4b8edfc.gif) Signing ready: ![image](https://user-images.githubusercontent.com/23693150/189167037-b6cb7d88-c3fc-4ce3-a13f-94e1d1f8883e.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 19:07:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#1574
No description provided.