[PR #276] [MERGED] Feat ✨ Chinese Genshin account management #1545

New issue

Closed

opened 2026-03-03 19:07:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/276
Author: @JoseMoreville
Created: 8/30/2022
Status: ✅ Merged
Merged: 9/1/2022
Merged by: @Depal1

Base: develop ← Head: hades-dev

📝 Commits (6)

08b512d Feat ✨ Chinese Genshin account management
186bc5b Update PlayCover/Utils/SaveGenshinUserData.swift
5847eb6 Update SaveGenshinUserData.swift
4549bde Feat: ✨ Now accounts are filtered according to bundleID on restore view
3ee778c Lint fix
a977025 New line between variable and body

📊 Changes

7 files changed (+65 additions, -53 deletions)

View changed files

📝 PlayCover/Utils/DeleteStoredGenshinUserData.swift (+1 -1)
📝 PlayCover/Utils/RestoreGenshinUserData.swift (+10 -6)
📝 PlayCover/Utils/SaveGenshinUserData.swift (+14 -11)
📝 PlayCover/View/ChangeGenshinAccountView.swift (+7 -8)
📝 PlayCover/View/DeleteGenshinStoredAccountView.swift (+2 -1)
📝 PlayCover/View/PlayAppView.swift (+4 -3)
📝 PlayCover/View/StoreGenshinAccountView.swift (+27 -23)

📄 Description

Fix: 🐛 Now you can delete accounts from storage correctly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/276 **Author:** [@JoseMoreville](https://github.com/JoseMoreville) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 9/1/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `hades-dev` --- ### 📝 Commits (6) - [`08b512d`](https://github.com/PlayCover/PlayCover/commit/08b512dba733a295b9f47263962b5beb9598f470) Feat :sparkles: Chinese Genshin account management - [`186bc5b`](https://github.com/PlayCover/PlayCover/commit/186bc5b97cff9358572c91058f1a47cf36dc901f) Update PlayCover/Utils/SaveGenshinUserData.swift - [`5847eb6`](https://github.com/PlayCover/PlayCover/commit/5847eb68a29b7fbdf540654f95e7bc64a430414a) Update SaveGenshinUserData.swift - [`4549bde`](https://github.com/PlayCover/PlayCover/commit/4549bde19c3296fbb0f38486148583a206b4404e) Feat: ✨ Now accounts are filtered according to bundleID on restore view - [`3ee778c`](https://github.com/PlayCover/PlayCover/commit/3ee778c8bc6ac8a136f7d8a46669cbdb1572e1d8) Lint fix - [`a977025`](https://github.com/PlayCover/PlayCover/commit/a97702531da586fe0545908e2a438e0d4d842edc) New line between variable and body ### 📊 Changes **7 files changed** (+65 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Utils/DeleteStoredGenshinUserData.swift` (+1 -1) 📝 `PlayCover/Utils/RestoreGenshinUserData.swift` (+10 -6) 📝 `PlayCover/Utils/SaveGenshinUserData.swift` (+14 -11) 📝 `PlayCover/View/ChangeGenshinAccountView.swift` (+7 -8) 📝 `PlayCover/View/DeleteGenshinStoredAccountView.swift` (+2 -1) 📝 `PlayCover/View/PlayAppView.swift` (+4 -3) 📝 `PlayCover/View/StoreGenshinAccountView.swift` (+27 -23) </details> ### 📄 Description Fix: :bug: Now you can delete accounts from storage correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>