[PR #152] [MERGED] fix: Reset all settings not resetting all settings #1486

New issue

Closed

opened 2026-03-03 19:07:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/152
Author: @ohaiibuzzle
Created: 8/12/2022
Status: ✅ Merged
Merged: 8/12/2022
Merged by: @Depal1

Base: develop ← Head: fix/reset-settings

📝 Commits (2)

42b3c1d fix: Reset all settings not resetting all settings
1c12b30 fix: Rewriting settings after resetting them (prevent unpredictable behaviors)

📊 Changes

2 files changed (+5 additions, -4 deletions)

View changed files

📝 PlayCover/Model/AppSettings.swift (+2 -4)
📝 PlayCover/View/AppSettingsView.swift (+3 -0)

📄 Description

Addresses #151

Fixed the reset() method which should now correctly nuke all settings for a given application

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/152 **Author:** [@ohaiibuzzle](https://github.com/ohaiibuzzle) **Created:** 8/12/2022 **Status:** ✅ Merged **Merged:** 8/12/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `fix/reset-settings` --- ### 📝 Commits (2) - [`42b3c1d`](https://github.com/PlayCover/PlayCover/commit/42b3c1d7db0e7cbeb803915f94d5288ae352eeab) fix: Reset all settings not resetting all settings - [`1c12b30`](https://github.com/PlayCover/PlayCover/commit/1c12b30590d8013136f15a2502af96c064992b84) fix: Rewriting settings after resetting them (prevent unpredictable behaviors) ### 📊 Changes **2 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppSettings.swift` (+2 -4) 📝 `PlayCover/View/AppSettingsView.swift` (+3 -0) </details> ### 📄 Description Addresses #151 Fixed the reset() method which should now correctly nuke all settings for a given application --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>