[PR #143] [MERGED] Refactor App Model Structure + Remove remaining `swiftlint: disable` statements #1483

New issue

Closed

opened 2026-03-03 19:07:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:07:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/143
Author: @IsaacMarovitz
Created: 8/5/2022
Status: ✅ Merged
Merged: 8/6/2022
Merged by: @Depal1

Base: develop ← Head: develop

📝 Commits (5)

ad61619 Refactor App Model Structure (Store links not yet re-implemented)
abe1d02 Remove remaining swiftlint:disable statements
c6de82d Added back store views
447586c Fixed wrong notices link
6640f2c Fixed search, fixed slow fetchApps()

📊 Changes

19 files changed (+328 additions, -469 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+7 -15)
📝 PlayCover/AppInstaller/Installer.swift (+128 -29)
📝 PlayCover/AppInstaller/Utils/Entitlements.swift (+12 -9)
📝 PlayCover/AppInstaller/Utils/IPA.swift (+2 -2)
📝 PlayCover/Model/AppInfo.swift (+3 -20)
📝 PlayCover/Model/BaseApp.swift (+13 -24)
➖ PlayCover/Model/InstallApp.swift (+0 -154)
➖ PlayCover/Model/PhysicialApp.swift (+0 -29)
📝 PlayCover/Model/PlayApp.swift (+2 -11)
➖ PlayCover/Model/StoreApp.swift (+0 -103)
📝 PlayCover/Utils/RestoreGenshinUserData.swift (+18 -19)
📝 PlayCover/Utils/SaveGenshinUserData.swift (+15 -16)
➕ PlayCover/Utils/Store.swift (+96 -0)
📝 PlayCover/Utils/URLExtensions.swift (+15 -0)
📝 PlayCover/View/AppsView.swift (+7 -11)
📝 PlayCover/View/MainView.swift (+1 -2)
📝 PlayCover/View/PlayAppView.swift (+0 -5)
📝 PlayCover/View/StoreAppView.swift (+4 -8)
📝 PlayCover/ViewModel/AppsVM.swift (+5 -12)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/143 **Author:** [@IsaacMarovitz](https://github.com/IsaacMarovitz) **Created:** 8/5/2022 **Status:** ✅ Merged **Merged:** 8/6/2022 **Merged by:** [@Depal1](https://github.com/Depal1) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (5) - [`ad61619`](https://github.com/PlayCover/PlayCover/commit/ad61619b87a24757807ac05d73aa0a4b93102b89) Refactor App Model Structure (Store links not yet re-implemented) - [`abe1d02`](https://github.com/PlayCover/PlayCover/commit/abe1d0262b351af4718c57b09def89a61a90e47c) Remove remaining `swiftlint:disable` statements - [`c6de82d`](https://github.com/PlayCover/PlayCover/commit/c6de82d0e7fb688372240accf154b5586cc37f60) Added back store views - [`447586c`](https://github.com/PlayCover/PlayCover/commit/447586caf22f59c5aa5d6ecbaa5c8ff9f0c55179) Fixed wrong notices link - [`6640f2c`](https://github.com/PlayCover/PlayCover/commit/6640f2cbae8fd09e3789fa6aa0e7869a9be14177) Fixed search, fixed slow fetchApps() ### 📊 Changes **19 files changed** (+328 additions, -469 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+7 -15) 📝 `PlayCover/AppInstaller/Installer.swift` (+128 -29) 📝 `PlayCover/AppInstaller/Utils/Entitlements.swift` (+12 -9) 📝 `PlayCover/AppInstaller/Utils/IPA.swift` (+2 -2) 📝 `PlayCover/Model/AppInfo.swift` (+3 -20) 📝 `PlayCover/Model/BaseApp.swift` (+13 -24) ➖ `PlayCover/Model/InstallApp.swift` (+0 -154) ➖ `PlayCover/Model/PhysicialApp.swift` (+0 -29) 📝 `PlayCover/Model/PlayApp.swift` (+2 -11) ➖ `PlayCover/Model/StoreApp.swift` (+0 -103) 📝 `PlayCover/Utils/RestoreGenshinUserData.swift` (+18 -19) 📝 `PlayCover/Utils/SaveGenshinUserData.swift` (+15 -16) ➕ `PlayCover/Utils/Store.swift` (+96 -0) 📝 `PlayCover/Utils/URLExtensions.swift` (+15 -0) 📝 `PlayCover/View/AppsView.swift` (+7 -11) 📝 `PlayCover/View/MainView.swift` (+1 -2) 📝 `PlayCover/View/PlayAppView.swift` (+0 -5) 📝 `PlayCover/View/StoreAppView.swift` (+4 -8) 📝 `PlayCover/ViewModel/AppsVM.swift` (+5 -12) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>