[PR #73] [MERGED] Adds more dns record types #88

Closed
opened 2026-03-04 23:24:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/73
Author: @nkakouros
Created: 10/25/2018
Status: Merged
Merged: 10/26/2018
Merged by: @samuelwilliams

Base: masterHead: records


📝 Commits (1)

  • 195e01c Adds more dns record types

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 src/RecursiveResolver.php (+9 -2)

📄 Description

I encountered a crash in the following situation.

I have php-dns running on one server. On another server that resolves via the first, I run apt-get update. On the first server, php-dns crashed with the error:

"Undefined index: DNS_SRV" in file "/usr/lib/php-dns/vendor/yswery/dns/src/RecursiveResolver.php" on line "48"

I added to the dns answers all the records that are mentioned in the (PHP documentation)[https://secure.php.net/manual/en/function.dns-get-record.php] but were missing from php-dns.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/73 **Author:** [@nkakouros](https://github.com/nkakouros) **Created:** 10/25/2018 **Status:** ✅ Merged **Merged:** 10/26/2018 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `master` ← **Head:** `records` --- ### 📝 Commits (1) - [`195e01c`](https://github.com/yswery/PHP-DNS-SERVER/commit/195e01c01fde9b9c97881ca0cb14b8361618ade4) Adds more dns record types ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/RecursiveResolver.php` (+9 -2) </details> ### 📄 Description I encountered a crash in the following situation. I have php-dns running on one server. On another server that resolves via the first, I run `apt-get update`. On the first server, `php-dns` crashed with the error: ``` "Undefined index: DNS_SRV" in file "/usr/lib/php-dns/vendor/yswery/dns/src/RecursiveResolver.php" on line "48" ``` I added to the dns answers all the records that are mentioned in the (PHP documentation)[https://secure.php.net/manual/en/function.dns-get-record.php] but were missing from php-dns. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 23:24:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PHP-DNS-SERVER#88
No description provided.