[PR #56] [MERGED] Encoder decoder #73

New issue

Closed

opened 2026-03-04 23:24:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/56
Author: @samuelwilliams
Created: 9/8/2018
Status: ✅ Merged
Merged: 9/15/2018
Merged by: @samuelwilliams

Base: master ← Head: EncoderDecoder

📝 Commits (10+)

eaad30d Separated encode methods to separate static class "Encoder".
f274cee Separated decode methods. Removed encode and decode methods from Server class.
954dee9 Code simplification.
4d2af07 New test for decodeQuestionResourceRecord().
c29b89e Merge branch 'master' of https://github.com/samuelwilliams/PHP-DNS-SERVER into EncoderDecoder
41164cc Updated PHPUnit to 5.7
3bdd27e Composer requires ext-json.
587b473 Removed deprecated functions.
6fdf3b6 Merge branch 'master' of https://github.com/yswery/PHP-DNS-SERVER into EncoderDecoder
f5e2851 Use earlier version of JSON ext.

📊 Changes

13 files changed (+754 additions, -586 deletions)

View changed files

📝 .coveralls.yml (+1 -1)
📝 .gitignore (+1 -0)
📝 .travis.yml (+2 -2)
📝 composer.json (+4 -3)
➖ phpunit.xml (+0 -24)
➕ phpunit.xml.dist (+29 -0)
➕ src/Decoder.php (+162 -0)
➕ src/Encoder.php (+140 -0)
📝 src/Server.php (+41 -319)
➕ tests/DecoderTest.php (+183 -0)
➕ tests/EncoderTest.php (+168 -0)
📝 tests/JsonResolverTest.php (+20 -8)
📝 tests/ServerTest.php (+3 -229)

📄 Description

Separates the Encoder and Decoder methods from the server class which has enabled increased unit testing. This has enabled much safer changes to the code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/56 **Author:** [@samuelwilliams](https://github.com/samuelwilliams) **Created:** 9/8/2018 **Status:** ✅ Merged **Merged:** 9/15/2018 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `master` ← **Head:** `EncoderDecoder` --- ### 📝 Commits (10+) - [`eaad30d`](https://github.com/yswery/PHP-DNS-SERVER/commit/eaad30da06589adf49f08be97fa58c984272daf0) Separated encode methods to separate static class "Encoder". - [`f274cee`](https://github.com/yswery/PHP-DNS-SERVER/commit/f274ceee9135bb271bcf557e0cfc3292c63c4876) Separated decode methods. Removed encode and decode methods from Server class. - [`954dee9`](https://github.com/yswery/PHP-DNS-SERVER/commit/954dee98db80d0ac7a022b5bafcc42b1d173ccf9) Code simplification. - [`4d2af07`](https://github.com/yswery/PHP-DNS-SERVER/commit/4d2af0786828f1f2a7995c8b890b7ce1167a2dad) New test for decodeQuestionResourceRecord(). - [`c29b89e`](https://github.com/yswery/PHP-DNS-SERVER/commit/c29b89e5b9b645699ae08e2b738e4508d0b02544) Merge branch 'master' of https://github.com/samuelwilliams/PHP-DNS-SERVER into EncoderDecoder - [`41164cc`](https://github.com/yswery/PHP-DNS-SERVER/commit/41164cc0cb7ad970fa9a58c98096f1d37436af8d) Updated PHPUnit to 5.7 - [`3bdd27e`](https://github.com/yswery/PHP-DNS-SERVER/commit/3bdd27e69f108a4f5251caeaf87f858b6bed6044) Composer requires ext-json. - [`587b473`](https://github.com/yswery/PHP-DNS-SERVER/commit/587b473dd50bc3615ba968fd5fca799e5f4e01df) Removed deprecated functions. - [`6fdf3b6`](https://github.com/yswery/PHP-DNS-SERVER/commit/6fdf3b6ef11847305117de18332a0d493bd15a24) Merge branch 'master' of https://github.com/yswery/PHP-DNS-SERVER into EncoderDecoder - [`f5e2851`](https://github.com/yswery/PHP-DNS-SERVER/commit/f5e2851a1a819370f6880536441181980a619563) Use earlier version of JSON ext. ### 📊 Changes **13 files changed** (+754 additions, -586 deletions) <details> <summary>View changed files</summary> 📝 `.coveralls.yml` (+1 -1) 📝 `.gitignore` (+1 -0) 📝 `.travis.yml` (+2 -2) 📝 `composer.json` (+4 -3) ➖ `phpunit.xml` (+0 -24) ➕ `phpunit.xml.dist` (+29 -0) ➕ `src/Decoder.php` (+162 -0) ➕ `src/Encoder.php` (+140 -0) 📝 `src/Server.php` (+41 -319) ➕ `tests/DecoderTest.php` (+183 -0) ➕ `tests/EncoderTest.php` (+168 -0) 📝 `tests/JsonResolverTest.php` (+20 -8) 📝 `tests/ServerTest.php` (+3 -229) </details> ### 📄 Description Separates the Encoder and Decoder methods from the server class which has enabled increased unit testing. This has enabled much safer changes to the code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>