mirror of
https://github.com/yswery/PHP-DNS-SERVER.git
synced 2026-04-26 01:35:57 +03:00
[GH-ISSUE #79] example.php does not fail if run without privileges #29
Labels
No labels
bug
enhancement
enhancement
hacktoberfest
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PHP-DNS-SERVER#29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nkakouros on GitHub (Nov 20, 2018).
Original GitHub issue: https://github.com/yswery/PHP-DNS-SERVER/issues/79
If you try to run
php examples/example.phpin a freshgit cloneof the project, the command returns and the exit code is 0. However, no server starts running in the background. If, however,sudo php examples/example.phpis given instead, the server loop is started successfully. It would be useful to output either an error message or return with a non-zero exit code.@samuelwilliams commented on GitHub (Jan 25, 2019):
@tterranigma - Does PR #84 solve the issue you've reported here?
@nkakouros commented on GitHub (Jan 26, 2019):
Almost, I think. There is an error message but the exit code is 0. Shouldn't it be at at least 1?
@raheelkhan commented on GitHub (Jan 28, 2019):
@tterranigma I have pushed the code that returns exit code 1 if there is any ServerExceptionEvent raised. Please verify. Thanks
@raheelkhan commented on GitHub (Apr 8, 2019):
Can we close this against PR #84 ?