[PR #654] [MERGED] 🐛 Add colon after scheme in error redirect URL #705

New issue

Closed

opened 2026-03-03 17:29:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/654
Author: @phatblat
Created: 5/3/2021
Status: ✅ Merged
Merged: 5/5/2021
Merged by: @phimage

Base: master ← Head: error-redirect

📝 Commits (1)

4969686 🐛 Add colon after scheme in error redirect URL

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Sources/Handler/ASWebAuthenticationURLHandler.swift (+1 -1)

📄 Description

Added a colon after the custom URL scheme given to ASWebAuthenticationURLHandler. This scheme is relayed to the ASWebAuthenticationSession constructor, but is also used to build a redirect URL when there is an error returned to the completionHandler. While the resulting urlString creates a valid URL, this URL can't be opened by UIKit without this colon.

Fixes #653

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/654 **Author:** [@phatblat](https://github.com/phatblat) **Created:** 5/3/2021 **Status:** ✅ Merged **Merged:** 5/5/2021 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `error-redirect` --- ### 📝 Commits (1) - [`4969686`](https://github.com/OAuthSwift/OAuthSwift/commit/49696862778e7f075f832b64379f8b5513312394) 🐛 Add colon after scheme in error redirect URL ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Handler/ASWebAuthenticationURLHandler.swift` (+1 -1) </details> ### 📄 Description Added a colon after the custom URL scheme given to `ASWebAuthenticationURLHandler`. This scheme is relayed to the [`ASWebAuthenticationSession` constructor](https://developer.apple.com/documentation/authenticationservices/aswebauthenticationsession/2990952-init), but is also used to build a redirect URL when there is an error returned to the `completionHandler`. While the resulting `urlString` creates a valid URL, this URL can't be opened by UIKit without this colon. Fixes #653 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>