[PR #514] [MERGED] Remove identical function handling OAuth2 request with PKCE and prevent crash #653

New issue

Closed

opened 2026-03-03 16:49:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/514
Author: @troligtvis
Created: 2/13/2019
Status: ✅ Merged
Merged: 2/13/2019
Merged by: @phimage

Base: master ← Head: master

📝 Commits (2)

447a47b Remove identical function which caused confusion for compiler
c52a5ed Merge pull request #1 from troligtvis/code/update-pkce-auth-function

📊 Changes

1 file changed (+3 additions, -11 deletions)

View changed files

📝 Sources/OAuth2Swift.swift (+3 -11)

📄 Description

This will prevent the app to go in a loop when trying to create an authorize function call with PKCE credentials, which in the end result in a crash.

This PR will fix #513

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/514 **Author:** [@troligtvis](https://github.com/troligtvis) **Created:** 2/13/2019 **Status:** ✅ Merged **Merged:** 2/13/2019 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`447a47b`](https://github.com/OAuthSwift/OAuthSwift/commit/447a47b3c21766ed1b2ea67f3159826608a1436c) Remove identical function which caused confusion for compiler - [`c52a5ed`](https://github.com/OAuthSwift/OAuthSwift/commit/c52a5ed9cb24b71397ee8d69a9d2b81c08dd5cb8) Merge pull request #1 from troligtvis/code/update-pkce-auth-function ### 📊 Changes **1 file changed** (+3 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuth2Swift.swift` (+3 -11) </details> ### 📄 Description This will prevent the app to go in a loop when trying to create an authorize function call with PKCE credentials, which in the end result in a crash. This PR will fix #513 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>