[PR #655] [MERGED] optionally change authorize url param names #704

New issue

Closed

opened 2026-03-03 17:29:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/655
Author: @daironmichel
Created: 5/13/2021
Status: ✅ Merged
Merged: 5/13/2021
Merged by: @phimage

Base: master ← Head: master

📝 Commits (1)

c351c8f optionally change authorize url param names

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 Sources/OAuth1Swift.swift (+8 -2)

📄 Description

@phimage you were right to reject my original pull request. It's was dumb on my part.

Your solution is better and did help in part. However it didn't allowed me to change the name of the params in the authorize url.

The idea is that instead of having the standard param names:
https://www.someprovider.com/authorize?oauth_token=<token>&oauth_consumer_key=<key>
You can change them to:
https://www.someprovider.com/authorize?token=<token>&key=<key>
which is how E*Trade requires it to be.

Thanks for your help!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/655 **Author:** [@daironmichel](https://github.com/daironmichel) **Created:** 5/13/2021 **Status:** ✅ Merged **Merged:** 5/13/2021 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c351c8f`](https://github.com/OAuthSwift/OAuthSwift/commit/c351c8f10bdad097cb71111add44df7b559e3979) optionally change authorize url param names ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuth1Swift.swift` (+8 -2) </details> ### 📄 Description @phimage you were right to reject my original pull request. It's was dumb on my part. Your solution is better and did help in part. However it didn't allowed me to change the name of the params in the authorize url. The idea is that instead of having the standard param names: `https://www.someprovider.com/authorize?oauth_token=<token>&oauth_consumer_key=<key>` You can change them to: `https://www.someprovider.com/authorize?token=<token>&key=<key>` which is how E*Trade requires it to be. Thanks for your help! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>