[PR #511] [MERGED] URL type support #655

New issue

Closed

opened 2026-03-03 16:49:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/511
Author: @armanarutiunov
Created: 2/6/2019
Status: ✅ Merged
Merged: 2/12/2019
Merged by: @phimage

Base: master ← Head: url-type-support

📝 Commits (5)

a1786ba added convenience methods with URL type arguments instead of String-URL
d30b449 Revert "added convenience methods with URL type arguments instead of String-URL"
ec24b90 added URLConvertible and switched all public String-URL parameters to it
a7f72c0 added URLConvertible to other targets
eca6e7f naming update

📊 Changes

6 files changed (+109 additions, -64 deletions)

View changed files

📝 OAuthSwift.xcodeproj/project.pbxproj (+10 -0)
📝 Sources/OAuth1Swift.swift (+8 -8)
📝 Sources/OAuth2Swift.swift (+15 -15)
📝 Sources/OAuthSwiftClient.swift (+22 -22)
📝 Sources/Objc.swift (+19 -19)
➕ Sources/URLConvertible.swift (+35 -0)

📄 Description

Most of the public methods of this library accept string-typed URLs. This is not very convenient for people who prefer constructing URLs with URL.appendingPathComponent(). This method allows you not to worry about a missed or overwritten slash and keeps it very clean and obvious.

In this PR I didn't change any part of the internal logic. Only duplicated public/open methods that accept string-typed URLs and changed the arguments to url-typed URLs that would call the original method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/511 **Author:** [@armanarutiunov](https://github.com/armanarutiunov) **Created:** 2/6/2019 **Status:** ✅ Merged **Merged:** 2/12/2019 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `url-type-support` --- ### 📝 Commits (5) - [`a1786ba`](https://github.com/OAuthSwift/OAuthSwift/commit/a1786bac151004e28ab0930de636acdcbc6c2cdd) added convenience methods with URL type arguments instead of String-URL - [`d30b449`](https://github.com/OAuthSwift/OAuthSwift/commit/d30b4499e80918e7a1fe794e1928abd7279c38b1) Revert "added convenience methods with URL type arguments instead of String-URL" - [`ec24b90`](https://github.com/OAuthSwift/OAuthSwift/commit/ec24b90cf81ee8f94ed39ac443fb4e62ca4be155) added URLConvertible and switched all public String-URL parameters to it - [`a7f72c0`](https://github.com/OAuthSwift/OAuthSwift/commit/a7f72c0d94cfd4fc820d7b2421b0f79d034b38ce) added URLConvertible to other targets - [`eca6e7f`](https://github.com/OAuthSwift/OAuthSwift/commit/eca6e7f3b23a756d11f00ba286912e071cc64d53) naming update ### 📊 Changes **6 files changed** (+109 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+10 -0) 📝 `Sources/OAuth1Swift.swift` (+8 -8) 📝 `Sources/OAuth2Swift.swift` (+15 -15) 📝 `Sources/OAuthSwiftClient.swift` (+22 -22) 📝 `Sources/Objc.swift` (+19 -19) ➕ `Sources/URLConvertible.swift` (+35 -0) </details> ### 📄 Description Most of the public methods of this library accept string-typed `URL`s. This is not very convenient for people who prefer constructing URLs with `URL.appendingPathComponent()`. This method allows you not to worry about a missed or overwritten slash and keeps it very clean and obvious. In this PR I didn't change any part of the internal logic. Only duplicated public/open methods that accept string-typed `URL`s and changed the arguments to url-typed `URL`s that would call the original method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>