[PR #572] [MERGED] Fix new warnings when building with Xcode 11.4 #677

Closed
opened 2026-03-03 17:29:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/572
Author: @deyton
Created: 2/6/2020
Status: Merged
Merged: 2/7/2020
Merged by: @phimage

Base: masterHead: xcode-11-4-warnings


📝 Commits (2)

  • 5a520da Avoid dangling pointer by using safe array method
  • d990ffd Use explicit tuple for pattern matching

📊 Changes

3 files changed (+13 additions, -5 deletions)

View changed files

📝 Sources/HMAC.swift (+6 -3)
📝 Sources/OAuth2Swift.swift (+1 -1)
📝 Sources/OAuthSwiftCredential.swift (+6 -1)

📄 Description

Xcode 11.4/Swift 5.2 came with a lot of changes in diagnostics, and there were a couple of warnings that popped up. I don't think there's anything risky here so hopefully it's helpful 😀


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/572 **Author:** [@deyton](https://github.com/deyton) **Created:** 2/6/2020 **Status:** ✅ Merged **Merged:** 2/7/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `xcode-11-4-warnings` --- ### 📝 Commits (2) - [`5a520da`](https://github.com/OAuthSwift/OAuthSwift/commit/5a520da09a310b62ada065796341e90d35734340) Avoid dangling pointer by using safe array method - [`d990ffd`](https://github.com/OAuthSwift/OAuthSwift/commit/d990ffd5dc6376a67533f57ff4102b3ed7c50c34) Use explicit tuple for pattern matching ### 📊 Changes **3 files changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Sources/HMAC.swift` (+6 -3) 📝 `Sources/OAuth2Swift.swift` (+1 -1) 📝 `Sources/OAuthSwiftCredential.swift` (+6 -1) </details> ### 📄 Description Xcode 11.4/Swift 5.2 came with a lot of changes in diagnostics, and there were a couple of warnings that popped up. I don't think there's anything risky here so hopefully it's helpful 😀 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 17:29:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#677
No description provided.