[PR #215] [MERGED] Provide a method on OAuthSwiftClient that accepts a plain NSURLRequest Fix #212. #572

New issue

Closed

opened 2026-03-03 16:49:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/215
Author: @FGoessler
Created: 4/3/2016
Status: ✅ Merged
Merged: 4/4/2016
Merged by: @phimage

Base: master ← Head: #212-NSURLRequest-support

📝 Commits (2)

b7dadb2 #212: fixed the OAuthSwiftHTTPRequest initializer that accepts an NSURLRequest
e2e85b8 #212: added a method to OAuthSwiftClient to perform requests via plain NSURLRequest objects

📊 Changes

4 files changed (+133 additions, -67 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftClient.swift (+71 -63)
📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+6 -4)
📝 OAuthSwiftTests/OAuthSwiftClientTests.swift (+27 -0)
📝 OAuthSwiftTests/OAuthSwiftRequestTests.swift (+29 -0)

📄 Description

Added a method on OAuthSwiftClient that accepts a plain NSURLRequest, creates an OAuthSwiftHTTPRequest object with it and starts that request as usually, like discussed in #212.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/215 **Author:** [@FGoessler](https://github.com/FGoessler) **Created:** 4/3/2016 **Status:** ✅ Merged **Merged:** 4/4/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `#212-NSURLRequest-support` --- ### 📝 Commits (2) - [`b7dadb2`](https://github.com/OAuthSwift/OAuthSwift/commit/b7dadb261b3f5fd827113da3543241d1ad0211c0) #212: fixed the OAuthSwiftHTTPRequest initializer that accepts an NSURLRequest - [`e2e85b8`](https://github.com/OAuthSwift/OAuthSwift/commit/e2e85b8177e36c96445b63f1b83dd48ba08f7742) #212: added a method to OAuthSwiftClient to perform requests via plain NSURLRequest objects ### 📊 Changes **4 files changed** (+133 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftClient.swift` (+71 -63) 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+6 -4) 📝 `OAuthSwiftTests/OAuthSwiftClientTests.swift` (+27 -0) 📝 `OAuthSwiftTests/OAuthSwiftRequestTests.swift` (+29 -0) </details> ### 📄 Description Added a method on OAuthSwiftClient that accepts a plain NSURLRequest, creates an OAuthSwiftHTTPRequest object with it and starts that request as usually, like discussed in #212. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>