[GH-ISSUE #526] Safari View Controller Failed to dismiss automatically #346

Closed
opened 2026-03-03 16:47:56 +03:00 by kerem · 3 comments
Owner

Originally created by @emiltsang on GitHub (Jun 10, 2019).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/526

Description:

After updated to OAuthSwift version 1.4.0 from 1.2.2, the Safari View Controller failed to dismiss automatically after successful login to Meetup.com.

Is there any methods to make the Safari View Controller dismiss automatically?

OAuth Provider? (Twitter, Github, ..):

Meetup.com

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS : 11.2

Installation method:

  • CocoaPods

Library version:

  • v1.4.0

Xcode version:

  • 10.2.1 (Swift 5.0)
Originally created by @emiltsang on GitHub (Jun 10, 2019). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/526 ### Description: After updated to OAuthSwift version 1.4.0 from 1.2.2, the Safari View Controller failed to dismiss automatically after successful login to Meetup.com. Is there any methods to make the Safari View Controller dismiss automatically? ### OAuth Provider? (Twitter, Github, ..): Meetup.com ### OAuth Version: - [ ] Version 1 - [x] Version 2 ### OS (Please fill the version) : - [x] iOS : 11.2 ### Installation method: - [x] CocoaPods ### Library version: - [x] v1.4.0 ### Xcode version: - [x] 10.2.1 (Swift 5.0)
kerem closed this issue 2026-03-03 16:47:57 +03:00
Author
Owner

@phimage commented on GitHub (Jun 10, 2019):

Maybe its because of my fix #522
Could you try by keeping a hard reference on your object set to authorizeURLHandler variable

<!-- gh-comment-id:500552666 --> @phimage commented on GitHub (Jun 10, 2019): Maybe its because of my fix #522 Could you try by keeping a hard reference on your object set to `authorizeURLHandler` variable
Author
Owner

@phimage commented on GitHub (Jun 10, 2019):

I will make a new release 1.4.1 to revert the change
and propose a new solution when needed to create a weak instead

<!-- gh-comment-id:500569861 --> @phimage commented on GitHub (Jun 10, 2019): I will make a new release 1.4.1 to revert the change and propose a new solution when needed to create a weak instead
Author
Owner

@phimage commented on GitHub (Jun 10, 2019):

1.4.1 created
I expect you have no more issue

<!-- gh-comment-id:500573802 --> @phimage commented on GitHub (Jun 10, 2019): 1.4.1 created I expect you have no more issue
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#346
No description provided.