[PR #123] [CLOSED] Check the http url response's status code before using it #526

New issue

Closed

opened 2026-03-03 16:49:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/123
Author: @sdduursma
Created: 10/7/2015
Status: ❌ Closed

Base: master ← Head: check-response-status-code-before-using

📝 Commits (1)

e3618c4 Check the http url response's status code before using it

📊 Changes

1 file changed (+9 additions, -8 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+9 -8)

📄 Description

Previously the NSHTTPURLResponse's status code passed to the completion handler of dataTaskWithRequest in start() in OAuthSwiftHTTPRequest was only checked after the response and data objects had been used. This PR fixes that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/123 **Author:** [@sdduursma](https://github.com/sdduursma) **Created:** 10/7/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `check-response-status-code-before-using` --- ### 📝 Commits (1) - [`e3618c4`](https://github.com/OAuthSwift/OAuthSwift/commit/e3618c4b30c805f015c6b58a4d62d18ec9196d53) Check the http url response's status code before using it ### 📊 Changes **1 file changed** (+9 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+9 -8) </details> ### 📄 Description Previously the NSHTTPURLResponse's status code passed to the completion handler of `dataTaskWithRequest` in `start()` in OAuthSwiftHTTPRequest was only checked after the response and data objects had been used. This PR fixes that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>