[GH-ISSUE #522] authorizeURLHandler is not weak, prevents view controller from being deallocated #344

New issue

Closed

opened 2026-03-03 16:47:55 +03:00 by kerem · 3 comments

kerem commented

2026-03-03 16:47:55 +03:00

Owner

Originally created by @miktav on GitHub (Mar 8, 2019).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/522

Once I set OAuth2Swift authorizeURLHandler to my view controller, my view controller is never getting deallocated.

I believe this is happening because authorizeURLHandler is not declared as weak:

open var authorizeURLHandler: OAuthSwiftURLHandlerType

My view controller's deinit is never called.

Originally created by @miktav on GitHub (Mar 8, 2019). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/522 Once I set OAuth2Swift authorizeURLHandler to my view controller, my view controller is never getting deallocated. I believe this is happening because authorizeURLHandler is not declared as weak: open var authorizeURLHandler: OAuthSwiftURLHandlerType My view controller's deinit is never called.

kerem closed this issue

2026-03-03 16:47:55 +03:00

kerem commented

2026-03-03 16:47:56 +03:00

Author

Owner

@phimage commented on GitHub (Jun 10, 2019):

possible workaround
oauthswift object as week in controller
or restore default authorizeURLHandler

@phimage commented on GitHub (Jun 10, 2019): possible workaround oauthswift object as week in controller or restore default authorizeURLHandler

kerem commented

2026-03-03 16:47:56 +03:00

Author

Owner

@phimage commented on GitHub (Jun 10, 2019):

I will propose a new solution in next version with explicit code to make weak
Because make weak for everybody could create some bugs like #526

@phimage commented on GitHub (Jun 10, 2019): I will propose a new solution in next version with explicit code to make weak Because make weak for everybody could create some bugs like #526

kerem commented

2026-03-03 16:47:56 +03:00

Author

Owner

@phimage commented on GitHub (Jun 10, 2019):

The solution to make weak by code

oauthswift.authorizeURLHandler = YourVariable.weak()

This will a proxy with weak reference

@phimage commented on GitHub (Jun 10, 2019): The solution to make weak by code ```swift oauthswift.authorizeURLHandler = YourVariable.weak() ``` This will a proxy with weak reference