starred/OAuthSwift

Fork 0

mirror of https://github.com/OAuthSwift/OAuthSwift.git synced 2026-04-26 12:45:52 +03:00

[GH-ISSUE #248] Can't seem to use SafariViewController #144

New issue

Closed

opened 2026-03-03 16:46:04 +03:00 by kerem · 7 comments

kerem commented

2026-03-03 16:46:04 +03:00

Owner

Originally created by @tunds on GitHub (Jul 7, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/248

Seems like i've set everything right but when trying to access the SafariViewController using the following

if #available(iOS 9.0, *) { oauthswift.authorize_url_handler = SafariURLHandler(viewController: self) } else { oauthswift.authorize_url_handler = AuthWebViewController() }

I get the following error in the console
2016-07-07 17:51:35.047 OAuthSwiftExample[402:76129] Warning: Attempt to present <SFSafariViewController: 0x14d49b10> on <OAuthSwiftExample.Auth: 0x14e39250> whose view is not in the window hierarchy!

Originally created by @tunds on GitHub (Jul 7, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/248 Seems like i've set everything right but when trying to access the SafariViewController using the following ` if #available(iOS 9.0, *) { oauthswift.authorize_url_handler = SafariURLHandler(viewController: self) } else { oauthswift.authorize_url_handler = AuthWebViewController() }` I get the following error in the console `2016-07-07 17:51:35.047 OAuthSwiftExample[402:76129] Warning: Attempt to present <SFSafariViewController: 0x14d49b10> on <OAuthSwiftExample.Auth: 0x14e39250> whose view is not in the window hierarchy!`

kerem

2026-03-03 16:46:04 +03:00

closed this issue
added the
help wanted
label

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@phimage commented on GitHub (Jul 7, 2016):

I think that this error indicate that we try to present the safari controller using self as parent (the one passed into SafariURLHandlerinit) but this selfcontroller is not displayed (or not into hierarchy) when you doing authentification

Maybe I have a temporary fix that could work for you (even if I think you use the wrong controller when doing init)
Try to edit SafariURLHandler class into OAuthSwiftURLHandlerType.swift
When controller is used, replace by UIViewController. topViewController(controller) or UIApplication.topViewController?

@phimage commented on GitHub (Jul 7, 2016): I think that this error indicate that we try to present the safari controller using `self` as parent (the one passed into `SafariURLHandler`init) but this `self`controller is not displayed (or not into hierarchy) when you doing authentification Maybe I have a temporary fix that could work for you (even if I think you use the wrong controller when doing init) Try to edit `SafariURLHandler` class into OAuthSwiftURLHandlerType.swift When `controller` is used, replace by `UIViewController. topViewController(controller)` or `UIApplication.topViewController?`

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@tunds commented on GitHub (Jul 7, 2016):

Hi there i'm not too sure i understand where to make the edits on which line in this class... Also the class that i'm calling this on is the rootviewcontroller as well reckon this could be the issue?

@tunds commented on GitHub (Jul 7, 2016): Hi there i'm not too sure i understand where to make the edits on which line in this class... Also the class that i'm calling this on is the rootviewcontroller as well reckon this could be the issue?

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@phimage commented on GitHub (Jul 7, 2016):

yes the controller passed must be the one currently displayed when launching authentification

@phimage commented on GitHub (Jul 7, 2016): yes the controller passed must be the one currently displayed when launching authentification

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@tunds commented on GitHub (Jul 7, 2016):

Ahh right okay so could you possible hint at which line to change since i'm a bit confused as to what i have to edit in that class

@tunds commented on GitHub (Jul 7, 2016): Ahh right okay so could you possible hint at which line to change since i'm a bit confused as to what i have to edit in that class

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@phimage commented on GitHub (Jul 7, 2016):

I talk first about a fix in oauthswift code and I think I say the file name and class
But to really fix your problem, it is in your code when you doing oauthswift.authorize_url_handler = SafariURLHandler(viewController: self) }
Do it into the view controller which launch the authentification, not appdeletage or something like that

@phimage commented on GitHub (Jul 7, 2016): I talk first about a fix in oauthswift code and I think I say the file name and class But to really fix your problem, it is in your code when you doing `oauthswift.authorize_url_handler = SafariURLHandler(viewController: self) }` Do it into the view controller which launch the authentification, not appdeletage or something like that

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@tunds commented on GitHub (Jul 7, 2016):

Hmmm see i've not done in the app delegate i've actually done it on the class which i want it do the app authentication on, as you can see below in my authentication class

` func doOAuthSoundCloud(consumerKey: String, consumerSecret: String) {

    let oauthswift = OAuth2Swift(
        consumerKey:    consumerKey,
        consumerSecret: consumerSecret,
        authorizeUrl:   authorizeUrl,
        accessTokenUrl: accessToken,
        responseType:   "code"
    )

    oauthswift.authorize_url_handler = SafariURLHandler(viewController: self)
    //oauthswift.authorize_url_handler = AuthWebViewController()

// if #available(iOS 9.0, *) {
//
// } else {
//
// }

    // Add safari and webview so it authenticated in app
    // Clean up code in model classes and root view controller

    let state: String = generateStateWithLength(20) as String
    oauthswift.authorizeWithCallbackURL( NSURL(string: callBackUrl)!, scope: "", state: state, success: {
        credential, response, parameters in
        // self.showTokenAlert(serviceParameters["name"], credential: credential)
        self.testSoundCloud(oauthswift,credential.oauth_token)
        }, failure: { error in
            print(error.localizedDescription)
    })
}`

and in my view controller when i want to login

`//
// ViewController.swift
// OAuthSwiftExample
//
// Created by Tunde Adegoroye on 07/07/2016.
// Copyright © 2016 Tunde Adegoroye. All rights reserved.
//

import UIKit

class ViewController: RootViewController {

@IBOutlet weak var loginBtn: UIButton!

override func viewDidLoad() {
    super.viewDidLoad()
    // Do any additional setup after loading the view, typically from a nib.

    // Do verification here

}

override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
}


@IBAction func loginBtnDidTouch(sender: AnyObject) {
            authMethods.doOAuthSoundCloud("xxxxxxxx", consumerSecret: "xxxxxxxxxxx")
}

}

@tunds commented on GitHub (Jul 7, 2016): Hmmm see i've not done in the app delegate i've actually done it on the class which i want it do the app authentication on, as you can see below in my authentication class ` func doOAuthSoundCloud(consumerKey: String, consumerSecret: String) { ``` let oauthswift = OAuth2Swift( consumerKey: consumerKey, consumerSecret: consumerSecret, authorizeUrl: authorizeUrl, accessTokenUrl: accessToken, responseType: "code" ) oauthswift.authorize_url_handler = SafariURLHandler(viewController: self) //oauthswift.authorize_url_handler = AuthWebViewController() ``` // if #available(iOS 9.0, *) { // // } else { // // } ``` // Add safari and webview so it authenticated in app // Clean up code in model classes and root view controller let state: String = generateStateWithLength(20) as String oauthswift.authorizeWithCallbackURL( NSURL(string: callBackUrl)!, scope: "", state: state, success: { credential, response, parameters in // self.showTokenAlert(serviceParameters["name"], credential: credential) self.testSoundCloud(oauthswift,credential.oauth_token) }, failure: { error in print(error.localizedDescription) }) }` ``` and in my view controller when i want to login `// // ViewController.swift // OAuthSwiftExample // // Created by Tunde Adegoroye on 07/07/2016. // Copyright © 2016 Tunde Adegoroye. All rights reserved. // import UIKit class ViewController: RootViewController { ``` @IBOutlet weak var loginBtn: UIButton! override func viewDidLoad() { super.viewDidLoad() // Do any additional setup after loading the view, typically from a nib. // Do verification here } override func didReceiveMemoryWarning() { super.didReceiveMemoryWarning() // Dispose of any resources that can be recreated. } @IBAction func loginBtnDidTouch(sender: AnyObject) { authMethods.doOAuthSoundCloud("xxxxxxxx", consumerSecret: "xxxxxxxxxxx") } ``` } `

kerem commented

2026-03-03 16:46:05 +03:00

Author

Owner

@tunds commented on GitHub (Jul 8, 2016):

Move authentication to the correct class and it's now working.

@tunds commented on GitHub (Jul 8, 2016): Move authentication to the correct class and it's now working.

kerem referenced this issue

2026-03-03 16:49:19 +03:00

[PR #144] [CLOSED] Fix #137 update readme with 'parameters' into callback #533