[GH-ISSUE #386] Making changes to SFSafariViewController class

kerem commented

2026-03-03 16:47:03 +03:00

Owner

Originally created by @dannymout on GitHub (Jun 29, 2017).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/386

With the changes introduced to SFSafariViewController in iOS 10, it makes it possible to customize it a lot more. I'm using SafariURLHandler, but how can I access the SafariVC to make changes?

OS (Please fill the version) :

iOS :
OSX :
TVOS :
WatchOS

Library version:

head
v1.0.0
v0.6
other: v1.1.2

Xcode version:

8.0 (Swift 3.0)
8.0 (Swift 2.3)
7.3.1
other: Xcode 9 and Swift 4

Originally created by @dannymout on GitHub (Jun 29, 2017). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/386 With the changes introduced to `SFSafariViewController` in iOS 10, it makes it possible to customize it a lot more. I'm using `SafariURLHandler`, but how can I access the SafariVC to make changes? ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS ### Library version: - [ ] head - [ ] v1.0.0 - [ ] v0.6 - [x] other: v1.1.2 ### Xcode version: - [ ] 8.0 (Swift 3.0) - [ ] 8.0 (Swift 2.3) - [ ] 7.3.1 - [x] other: Xcode 9 and Swift 4

kerem

2026-03-03 16:47:03 +03:00

closed this issue
added the
question
label

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@phimage commented on GitHub (Jun 30, 2017):

you can set a factory SafariURLHandler#factory
see https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/OAuthSwiftURLHandlerType.swift

then there is also

open var animated: Bool = true
open var presentCompletion: (() -> Void)?
open var dismissCompletion: (() -> Void)?

@phimage commented on GitHub (Jun 30, 2017): you can set a factory `SafariURLHandler#factory` see https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/OAuthSwiftURLHandlerType.swift then there is also ```swift open var animated: Bool = true open var presentCompletion: (() -> Void)? open var dismissCompletion: (() -> Void)? ```

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@dannymout commented on GitHub (Jul 4, 2017):

@phimage OK, so how does SafariURLHandler#factory work? Do you have a short code example?

@dannymout commented on GitHub (Jul 4, 2017): @phimage OK, so how does `SafariURLHandler#factory` work? Do you have a short code example?

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@phimage commented on GitHub (Jul 4, 2017):

.factory = { safari in

}

Simple closure

@phimage commented on GitHub (Jul 4, 2017): .factory = { safari in } Simple closure

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@dannymout commented on GitHub (Jul 4, 2017):

@phimage 'safari' is of type URL, that's why I was getting confused with SafariURLHandler#factory.

@dannymout commented on GitHub (Jul 4, 2017): @phimage 'safari' is of type URL, that's why I was getting confused with `SafariURLHandler#factory`.

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@phimage commented on GitHub (Jul 4, 2017):

Sorry
, just read the closure type

.factory = { url in
return SafaryXxxxxx(url :url)
}

@phimage commented on GitHub (Jul 4, 2017): Sorry , just read the closure type .factory = { url in return SafaryXxxxxx(url :url) }

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@phimage commented on GitHub (Jul 5, 2017):

ya but you not post your code, so how I can help? The error message is clear.

please look at demo code in
https://github.com/OAuthSwift/OAuthSwift/blob/master/Demo/Common/ViewController.swift
commited by
github.com/OAuthSwift/OAuthSwift@aceae6aaad
look for
SafariURLHandler

@phimage commented on GitHub (Jul 5, 2017): ya but you not post your code, so how I can help? The error message is clear. please look at demo code in https://github.com/OAuthSwift/OAuthSwift/blob/master/Demo/Common/ViewController.swift commited by https://github.com/OAuthSwift/OAuthSwift/commit/aceae6aaad5d3d5930f74119fadcdb4cdc2b5f52 look for `SafariURLHandler`

kerem commented

2026-03-03 16:47:04 +03:00

Author

Owner

@dannymout commented on GitHub (Jul 6, 2017):

@phimage Nevermind Xcode seemed to be acting up. When I looked over the code, mine looked the same, so I tried uncommenting what I wrote, and everything is fine. Thanks!

@dannymout commented on GitHub (Jul 6, 2017): @phimage Nevermind Xcode seemed to be acting up. When I looked over the code, mine looked the same, so I tried uncommenting what I wrote, and everything is fine. Thanks!