[PR #3] [MERGED] Find and fix a verifiable bug with tests #3

New issue

Closed

opened 2026-02-27 20:18:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:18:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NodeDaemon/NodeDaemon/pull/3
Author: @ersinkoc
Created: 11/5/2025
Status: ✅ Merged
Merged: 11/5/2025
Merged by: @ersinkoc

Base: main ← Head: claude/identify-and-fix-bug-011CUpiRtuykqgjV96ntLW4Q

📝 Commits (1)

9115e8d fix: replace Math.random() with 0 for Windows CPU metrics

📊 Changes

3 files changed (+330 additions, -1 deletions)

View changed files

📝 src/core/HealthMonitor.ts (+3 -1)
➕ tests/unit/health-monitor-cpu-bug.test.js (+205 -0)
➕ tests/unit/health-monitor-no-random-cpu.test.js (+122 -0)

📄 Description

Bug: HealthMonitor.getWindowsMetrics() was using Math.random() * 10 as the CPU percentage value when typeperf output parsing was incomplete. This resulted in random, incorrect CPU metrics on Windows systems.

Impact:

Windows users saw random CPU percentages (0-10%) instead of actual values
Health monitoring and CPU-based alerts were unreliable
Metrics displayed in WebUI/CLI were misleading

Fix:

Replaced Math.random() * 10 with 0 (accurate representation of "unable to determine CPU usage")
Added TODO comment to implement proper typeperf output parsing
CPU metrics now return deterministic, honest values

Tests:

Added health-monitor-no-random-cpu.test.js to verify source code doesn't contain Math.random() in CPU metrics code
Added health-monitor-cpu-bug.test.js for runtime verification
All existing tests continue to pass (55/58 success rate maintained)

Location: src/core/HealthMonitor.ts:375

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NodeDaemon/NodeDaemon/pull/3 **Author:** [@ersinkoc](https://github.com/ersinkoc) **Created:** 11/5/2025 **Status:** ✅ Merged **Merged:** 11/5/2025 **Merged by:** [@ersinkoc](https://github.com/ersinkoc) **Base:** `main` ← **Head:** `claude/identify-and-fix-bug-011CUpiRtuykqgjV96ntLW4Q` --- ### 📝 Commits (1) - [`9115e8d`](https://github.com/NodeDaemon/NodeDaemon/commit/9115e8d071558837bf2b53a98a4535cf39395360) fix: replace Math.random() with 0 for Windows CPU metrics ### 📊 Changes **3 files changed** (+330 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/HealthMonitor.ts` (+3 -1) ➕ `tests/unit/health-monitor-cpu-bug.test.js` (+205 -0) ➕ `tests/unit/health-monitor-no-random-cpu.test.js` (+122 -0) </details> ### 📄 Description Bug: HealthMonitor.getWindowsMetrics() was using Math.random() * 10 as the CPU percentage value when typeperf output parsing was incomplete. This resulted in random, incorrect CPU metrics on Windows systems. Impact: - Windows users saw random CPU percentages (0-10%) instead of actual values - Health monitoring and CPU-based alerts were unreliable - Metrics displayed in WebUI/CLI were misleading Fix: - Replaced Math.random() * 10 with 0 (accurate representation of "unable to determine CPU usage") - Added TODO comment to implement proper typeperf output parsing - CPU metrics now return deterministic, honest values Tests: - Added health-monitor-no-random-cpu.test.js to verify source code doesn't contain Math.random() in CPU metrics code - Added health-monitor-cpu-bug.test.js for runtime verification - All existing tests continue to pass (55/58 success rate maintained) Location: src/core/HealthMonitor.ts:375 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:18:23 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/NodeDaemon#3

No description provided.

Rows
Columns