starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 22:25:59 +03:00

[GH-ISSUE #1098] backupsdays backup autoclear #863

New issue

Closed

opened 2026-02-27 02:53:58 +03:00 by kerem · 9 comments

kerem commented

2026-02-27 02:53:58 +03:00

Owner

Originally created by @UltimateByte on GitHub (Oct 4, 2016).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1098

Originally assigned to: @UltimateByte on GitHub.

It won't be very hard to implement and will allow people to run it as a cronjob.
We can use this as a template : https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/logs.sh#L49

Must-have would be to check if a backup is already pending before starting another, in case somebody messes up and runs the cronjob every minute instead of every day for example.

Settings the amount of backups to keep would be added to the main script with a backupdays variable, and a value of "0" would mean "infinite".

I'll probably code a bit in the next days or weeks, so i'm assigning myself.

Originally created by @UltimateByte on GitHub (Oct 4, 2016). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1098 Originally assigned to: @UltimateByte on GitHub. It won't be very hard to implement and will allow people to run it as a cronjob. We can use this as a template : https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/logs.sh#L49 Must-have would be to check if a backup is already pending before starting another, in case somebody messes up and runs the cronjob every minute instead of every day for example. Settings the amount of backups to keep would be added to the main script with a backupdays variable, and a value of "0" would mean "infinite". I'll probably code a bit in the next days or weeks, so i'm assigning myself.

kerem closed this issue

2026-02-27 02:53:58 +03:00

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 19, 2016):

So, when should this backup clear occur ?
Upon backup ? Upon start, like logs do ?

Edit: The sward of truth sliced !
"dgibbs - Today at 10:04 PM
Hmmm
good question
at a guess after a successful backup"

@UltimateByte commented on GitHub (Oct 19, 2016): So, when should this backup clear occur ? Upon backup ? Upon start, like logs do ? Edit: The sward of truth sliced ! "dgibbs - Today at 10:04 PM Hmmm good question at a guess after a successful backup"

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 20, 2016):

Well, i'm quite happy, this is going pretty well.
I used the occasion to improve the backup slightly with nice comment,s removing useless echo "", adding the lockfile and backup clear.
Sample output: http://image.noelshack.com/fichiers/2016/42/1476925134-backups.png
Tested the backup clear, working as well.
Forgot the idea of infinite backups for now.

Found out another minor issue, fixed as well https://github.com/GameServerManagers/LinuxGSM/issues/1140

Next steps :

Add some script logs
Improve outputs a bit
Add backupdays="90" to all game scripts.

@UltimateByte commented on GitHub (Oct 20, 2016): Well, i'm quite happy, this is going pretty well. I used the occasion to improve the backup slightly with nice comment,s removing useless echo "", adding the lockfile and backup clear. Sample output: http://image.noelshack.com/fichiers/2016/42/1476925134-backups.png Tested the backup clear, working as well. Forgot the idea of infinite backups for now. Found out another minor issue, fixed as well https://github.com/GameServerManagers/LinuxGSM/issues/1140 Next steps : - Add some script logs - Improve outputs a bit - Add `backupdays="90"` to all game scripts.

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 20, 2016):

Logs output:

Oct 20 16:37:14 mumble-server: PASS: Updating functions
Oct 20 16:37:14 mumble-server: PASS: core_getopt.sh exiting with code: 0
Oct 20 16:37:22 mumble-server: START: INFO: Rotating log files
Oct 20 16:37:23 mumble-server: START: PASS: Started Mumble Port 64739
Oct 20 16:37:23 mumble-server: START: PASS: command_start.sh exiting with code: 0
Oct 20 16:37:26 mumble-server: BACKUP: Entering backup
Oct 20 16:37:27 mumble-server: BACKUP: A total of 34M will be compressed into the following backup: /home/ultimatebyte/backups/mumble-server-2016-10-20-163726.tar.gz
Oct 20 16:37:28 mumble-server: BACKUP: User validates
Oct 20 16:37:28 mumble-server: BACKUP: WARN: mumble-server is currently running.
Oct 20 16:37:31 mumble-server: BACKUP: User choose to stop the server
Oct 20 16:37:33 mumble-server: STOP: INFO: tmux kill-session: Mumble Port 64739
Oct 20 16:37:35 mumble-server: STOP: PASS: Stopped Mumble Port 64739
Oct 20 16:37:35 mumble-server: STOP: PASS: Stopped Mumble Port 64739
Oct 20 16:37:35 mumble-server: BACKUP: INFO: Initiating backup
Oct 20 16:37:36 mumble-server: BACKUP: INFO: Creating /home/ultimatebyte/backups
Oct 20 16:37:36 mumble-server: BACKUP: Lockfile created
Oct 20 16:37:36 mumble-server: BACKUP: Compressing 34M...
Oct 20 16:37:37 mumble-server: BACKUP: Compression over.
Oct 20 16:37:37 mumble-server: BACKUP: Lockfile removed
Oct 20 16:37:38 mumble-server: BACKUP: PASS: Backup created: /home/ultimatebyte/backups/mumble-server-2016-10-20-163726.tar.gz is 13M size
Oct 20 16:37:38 mumble-server: BACKUP: No backups older than 0 days were found.
Oct 20 16:37:39 mumble-server: START: INFO: Rotating log files
Oct 20 16:37:40 mumble-server: START: PASS: Started Mumble Port 64739
Oct 20 16:37:41 mumble-server: BACKUP: PASS: command_backup.sh exiting with code: 0

@UltimateByte commented on GitHub (Oct 20, 2016): ![backup output new](https://cloud.githubusercontent.com/assets/8805941/19564485/05755fc2-96e4-11e6-8680-7b9f590202d5.PNG) Logs output: ``` Oct 20 16:37:14 mumble-server: PASS: Updating functions Oct 20 16:37:14 mumble-server: PASS: core_getopt.sh exiting with code: 0 Oct 20 16:37:22 mumble-server: START: INFO: Rotating log files Oct 20 16:37:23 mumble-server: START: PASS: Started Mumble Port 64739 Oct 20 16:37:23 mumble-server: START: PASS: command_start.sh exiting with code: 0 Oct 20 16:37:26 mumble-server: BACKUP: Entering backup Oct 20 16:37:27 mumble-server: BACKUP: A total of 34M will be compressed into the following backup: /home/ultimatebyte/backups/mumble-server-2016-10-20-163726.tar.gz Oct 20 16:37:28 mumble-server: BACKUP: User validates Oct 20 16:37:28 mumble-server: BACKUP: WARN: mumble-server is currently running. Oct 20 16:37:31 mumble-server: BACKUP: User choose to stop the server Oct 20 16:37:33 mumble-server: STOP: INFO: tmux kill-session: Mumble Port 64739 Oct 20 16:37:35 mumble-server: STOP: PASS: Stopped Mumble Port 64739 Oct 20 16:37:35 mumble-server: STOP: PASS: Stopped Mumble Port 64739 Oct 20 16:37:35 mumble-server: BACKUP: INFO: Initiating backup Oct 20 16:37:36 mumble-server: BACKUP: INFO: Creating /home/ultimatebyte/backups Oct 20 16:37:36 mumble-server: BACKUP: Lockfile created Oct 20 16:37:36 mumble-server: BACKUP: Compressing 34M... Oct 20 16:37:37 mumble-server: BACKUP: Compression over. Oct 20 16:37:37 mumble-server: BACKUP: Lockfile removed Oct 20 16:37:38 mumble-server: BACKUP: PASS: Backup created: /home/ultimatebyte/backups/mumble-server-2016-10-20-163726.tar.gz is 13M size Oct 20 16:37:38 mumble-server: BACKUP: No backups older than 0 days were found. Oct 20 16:37:39 mumble-server: START: INFO: Rotating log files Oct 20 16:37:40 mumble-server: START: PASS: Started Mumble Port 64739 Oct 20 16:37:41 mumble-server: BACKUP: PASS: command_backup.sh exiting with code: 0 ```

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 20, 2016):

So, checklist

make backup noprompt in any case > DONE
add 3 default variables: stoponbackup="on"; maxbackups="4"; maxbackupdays="30" > DONE
need to find an efficient way for maxbackups > DONE
give info that the server will shutdown and give some time to abort > DONE
check available disk space before backing up > Will be done through this https://github.com/GameServerManagers/LinuxGSM/issues/704

@UltimateByte commented on GitHub (Oct 20, 2016): So, checklist - make backup noprompt in any case > DONE - add 3 default variables: stoponbackup="on"; maxbackups="4"; maxbackupdays="30" > DONE - need to find an efficient way for maxbackups > DONE - give info that the server will shutdown and give some time to abort > DONE - check available disk space before backing up > Will be done through this https://github.com/GameServerManagers/LinuxGSM/issues/704

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 21, 2016):

This will be to be reviewed tomorrow, but i think it's mostly done, everything works as intended.

@UltimateByte commented on GitHub (Oct 21, 2016): This will be to be reviewed tomorrow, but i think it's mostly done, everything works as intended. ![backup beauty](https://cloud.githubusercontent.com/assets/8805941/19584411/8c61f36e-9744-11e6-9d2e-49b6efd86e04.PNG)

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 21, 2016):

Removed the "x backups will be cleared" that was a test echo, improved comments, and i think it's ready to go. Pull requested to dev branch.

@UltimateByte commented on GitHub (Oct 21, 2016): Removed the "x backups will be cleared" that was a test echo, improved comments, and i think it's ready to go. Pull requested to dev branch.

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 28, 2016):

Edited the wiki

https://github.com/GameServerManagers/LinuxGSM/wiki/Backup

@UltimateByte commented on GitHub (Oct 28, 2016): Edited the wiki https://github.com/GameServerManagers/LinuxGSM/wiki/Backup

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@UltimateByte commented on GitHub (Oct 31, 2016):

Merged.

@UltimateByte commented on GitHub (Oct 31, 2016): Merged.

kerem commented

2026-02-27 02:53:59 +03:00

Author

Owner

@lock[bot] commented on GitHub (Jul 19, 2018):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Jul 19, 2018): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.