[PR #1326] [MERGED] Fix logs keep being created with some games with a more general way of handling logs #3318

New issue

Closed

opened 2026-02-27 03:54:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 03:54:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/1326
Author: @UltimateByte
Created: 2/19/2017
Status: ✅ Merged
Merged: 2/19/2017
Merged by: @dgibbs64

Base: master ← Head: hotfix/ultimatebyte-0219

📝 Commits (3)

7d7b448 More general way of handling logs
c9db31d comment
90f03ae repaired broken command by removing old "done"

📊 Changes

2 files changed (+10 additions, -11 deletions)

View changed files

📝 lgsm/functions/command_console.sh (+0 -1)
📝 lgsm/functions/install_logs.sh (+10 -10)

📄 Description

gamelogdir needs to be created if variable is set, otherwise check_logs.sh will attempt to create it upon almost any command if the server wasn't started yet and directory doesn't exist, as per https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/check_logs.sh#L24

symlink is done if gamelogdir variable is set rather than checking for what game it is, and after gamelogdir has been created (this order doesn't change anything, just a bit more elegant).

To sum up: Working with if [ -n $"{gamelogdir}" }] is a more general and simple way of doing it and shouldn't cause any kind of issue as long as gamelogdir variable is set to the proper path.

Thanks @Khelgar for reporting the issue

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/1326 **Author:** [@UltimateByte](https://github.com/UltimateByte) **Created:** 2/19/2017 **Status:** ✅ Merged **Merged:** 2/19/2017 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `master` ← **Head:** `hotfix/ultimatebyte-0219` --- ### 📝 Commits (3) - [`7d7b448`](https://github.com/GameServerManagers/LinuxGSM/commit/7d7b448a10584c20a242b1f359a477daca90c84d) More general way of handling logs - [`c9db31d`](https://github.com/GameServerManagers/LinuxGSM/commit/c9db31d17c4f4723330eedbed99404ce03336a93) comment - [`90f03ae`](https://github.com/GameServerManagers/LinuxGSM/commit/90f03aea5e0d98470b76ce0ebecdda6a94adc620) repaired broken command by removing old "done" ### 📊 Changes **2 files changed** (+10 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/command_console.sh` (+0 -1) 📝 `lgsm/functions/install_logs.sh` (+10 -10) </details> ### 📄 Description `gamelogdir `needs to be created if variable is set, otherwise `check_logs.sh` will attempt to create it upon almost any command if the server wasn't started yet and directory doesn't exist, as per https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/check_logs.sh#L24 symlink is done if `gamelogdir` variable is set rather than checking for what game it is, and after gamelogdir has been created (this order doesn't change anything, just a bit more elegant). To sum up: Working with `if [ -n $"{gamelogdir}" }]` is a more general and simple way of doing it and shouldn't cause any kind of issue as long as gamelogdir variable is set to the proper path. Thanks @Khelgar for reporting the issue --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

Rows
Columns