[GH-ISSUE #2056] Var extip in info_distro.sh never gets populated? #1603

New issue

Closed

opened 2026-02-27 02:58:04 +03:00 by kerem · 3 comments

kerem commented

2026-02-27 02:58:04 +03:00

Owner

Originally created by @Bourne-ID on GitHub (Oct 23, 2018).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2056

Code in question: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_distro.sh#L165-L174

The cURL command appears to be incorrect as the variable extip is always going to be null - the command is directing the cURL output to file and any errors to /dev/null. Likewise if the command exit code is a failure code then it either echos the file location, or x.x.x.x if the file doesn't exist.

This doesn't seem correct given the variable usage, but I'm struggling to understand why a temporary file was used. Is there something I'm missing, or can the use of a temporary file be removed and the error handling of the command made more descriptive?

(Thanks to Coldster#4940 which pointed out the oddity)

Thanks,

Originally created by @Bourne-ID on GitHub (Oct 23, 2018). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/2056 Code in question: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_distro.sh#L165-L174 The cURL command appears to be incorrect as the variable extip is always going to be null - the command is directing the cURL output to file and any errors to /dev/null. Likewise if the command exit code is a failure code then it either echos the file location, or x.x.x.x if the file doesn't exist. This doesn't seem correct given the variable usage, but I'm struggling to understand why a temporary file was used. Is there something I'm missing, or can the use of a temporary file be removed and the error handling of the command made more descriptive? (Thanks to Coldster#4940 which pointed out the oddity) Thanks,

kerem

2026-02-27 02:58:04 +03:00

closed this issue
added the
type: bug

outcome: issue resolved
labels

kerem commented

2026-02-27 02:58:05 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Nov 1, 2018):

I remember the txt file being created to reduce the queries to ifconfig.co as there is a rate limit. But yeah I doesnt look right. the code will need to be reviewed

@dgibbs64 commented on GitHub (Nov 1, 2018): I remember the txt file being created to reduce the queries to ifconfig.co as there is a rate limit. But yeah I doesnt look right. the code will need to be reviewed

kerem commented

2026-02-27 02:58:05 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Nov 23, 2018):

1127c0b202

@dgibbs64 commented on GitHub (Nov 23, 2018): 1127c0b202f784f83af848a9f0ada69b1d8bb768

kerem commented

2026-02-27 02:58:05 +03:00

Author

Owner

@lock[bot] commented on GitHub (Nov 23, 2019):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Nov 23, 2019): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.