starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 22:25:59 +03:00

[GH-ISSUE #1327] gamelogdir has to be reworked #1029

New issue

Closed

opened 2026-02-27 02:54:55 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 02:54:55 +03:00

Owner

Originally created by @marvinlehmann on GitHub (Feb 20, 2017).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1327

Originally assigned to: @marvinlehmann, @dgibbs64, @UltimateByte on GitHub.

Many servers have gamelogdir="${rootdir}/log/server" which isn't really desired, is it? (unnecessary symbolic linkception). Just search for gamelogdir="${rootdir}/log/server" to find some of them. (also mumble?)

Furthermore the server log should be set to the correct file (e.g. Hurtworld just uses "gamelog.txt" currently; Teeworlds is misconfigured; ..).

Moreover "gamelogfile" which doesn't even exist (?) is used in the following check: logs.sh#L20
I guess it should have been "gamelogdir"?

Originally created by @marvinlehmann on GitHub (Feb 20, 2017). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1327 Originally assigned to: @marvinlehmann, @dgibbs64, @UltimateByte on GitHub. Many servers have ` gamelogdir="${rootdir}/log/server"` which isn't really desired, is it? (unnecessary symbolic linkception). Just [search for gamelogdir="${rootdir}/log/server"](https://github.com/GameServerManagers/LinuxGSM/search?utf8=%E2%9C%93&q=gamelogdir%3D%22%24%7Brootdir%7D%2Flog%2Fserver%22&type=Code) to find some of them. (also mumble?) Furthermore the server log should be set to the correct file (e.g. Hurtworld just uses "gamelog.txt" currently; Teeworlds is misconfigured; ..). Moreover "gamelogfile" which doesn't even exist (?) is used in the following check: [logs.sh#L20](https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/logs.sh#L20) I guess it should have been "gamelogdir"?

kerem

2026-02-27 02:54:55 +03:00

closed this issue
added the
type: bug

type: feature
labels

kerem commented

2026-02-27 02:54:56 +03:00

Author

Owner

@UltimateByte commented on GitHub (Feb 20, 2017):

You're right, I felt there was something wrong when working on gamelogdir which is useful to some games, but appeared to be unnecessary for others. This needs an overhaul revision.

I didn't remember Hurtworld having a fixed log name, this needs to be addressed. Thanks for pointing this out.

As for -n "${gamelogfile} , here logs.sh#L20 this was a bit messy and is now a legacy function, but it is actually intended to check for gamelogfile.
Rust didn't have a custom log location, so it was into serverfiles by default, and had to be moved into gamelogdir upon server start, and Rust log was set within ${gamelogfile} var which didn't include ${gamelogdir} as it wouldn't work.
I did the revision for Rust that now supports custom logdir. It's more simple to look at the commit to understand: github.com/GameServerManagers/LinuxGSM@92f748c1ca (diff-34f056db9e)
It is now set with ${gamelogdate} like any other server that allows custom log location/file.

Also, I used 7dtd as a template, and shouldn't have.
Many games have a useless: gamelog="${gamelogdir}/${servicename}-game.log" which needs to be removed and ${gamelogdate} needs to be used instead. Same goes for 7dtd as well that generates date in fn_parm which is very bad.

(edited, don't read in email)

@UltimateByte commented on GitHub (Feb 20, 2017): You're right, I felt there was something wrong when working on gamelogdir which is useful to some games, but appeared to be unnecessary for others. This needs an overhaul revision. I didn't remember Hurtworld having a fixed log name, this needs to be addressed. Thanks for pointing this out. As for `-n "${gamelogfile}` , here [logs.sh#L20](https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/logs.sh#L20) this was a bit messy and is now a legacy function, but it is actually intended to check for gamelogfile. Rust didn't have a custom log location, so it was into serverfiles by default, and had to be moved into gamelogdir upon server start, and Rust log was set within ${gamelogfile} var which didn't include ${gamelogdir} as it wouldn't work. I did the revision for Rust that now supports custom logdir. It's more simple to look at the commit to understand: https://github.com/GameServerManagers/LinuxGSM/commit/92f748c1ca47cad2b120572c5d44402bc0c02af5#diff-34f056db9e8692880a2f240fa083de4c It is now set with ${gamelogdate} like any other server that allows custom log location/file. Also, I used 7dtd as a template, and shouldn't have. Many games have a useless: `gamelog="${gamelogdir}/${servicename}-game.log"` which needs to be removed and ${gamelogdate} needs to be used instead. Same goes for 7dtd as well that generates date in fn_parm which is very bad. (edited, don't read in email)

kerem commented

2026-02-27 02:54:56 +03:00

Author

Owner

@UltimateByte commented on GitHub (Feb 20, 2017):

Seing this and gamelogdir usage, it looks like something is wrong in variables management.

Here is how i think it should be:
gamelogdir would only exist if game server has default logs OR we can set custom log location. In any case, gamelogdir="${rootdir}/log/server".
Then another variable would be required for default server logs that we cannot change, like defaultgamelogdir=${systemdir}/location/of/logs.
Then symlink would be:

if [ -n "${defaultgamelogdir}" ]&&[ ! -L "${gamelogdir}" ]; then
	ln -nfsv "${defaultgamelogdir}" "${gamelogdir}"

And then gamelogdir creation would be:

elif [ -n "${gamelogdir}" &&[ ! -d "${gamelogdir}" ]]&&[ -z "${defaultgamelogdir}"  ]; then
	mkdir -pv "${gamelogdir}"
fi

Note: After some research, it looks like -h is legacy check and should be replaced with -L (check if it is a symlink). https://www.freebsd.org/cgi/man.cgi?test

@UltimateByte commented on GitHub (Feb 20, 2017): Seing [this](https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/install_logs.sh#L34) and `gamelogdir` usage, it looks like something is wrong in variables management. Here is how i think it should be: `gamelogdir` would only exist if game server has default logs OR we can set custom log location. In any case, `gamelogdir="${rootdir}/log/server"`. Then another variable would be required for default server logs that we cannot change, like `defaultgamelogdir=${systemdir}/location/of/logs`. Then symlink would be: ```bash if [ -n "${defaultgamelogdir}" ]&&[ ! -L "${gamelogdir}" ]; then ln -nfsv "${defaultgamelogdir}" "${gamelogdir}" ``` And then `gamelogdir` creation would be: ```bash elif [ -n "${gamelogdir}" &&[ ! -d "${gamelogdir}" ]]&&[ -z "${defaultgamelogdir}" ]; then mkdir -pv "${gamelogdir}" fi ``` Note: After some research, it looks like `-h` is legacy check and should be replaced with `-L` (check if it is a symlink). https://www.freebsd.org/cgi/man.cgi?test

kerem commented

2026-02-27 02:54:56 +03:00

Author

Owner

@dgibbs64 commented on GitHub (May 15, 2017):

My current solution required no extra vars

# Symlink to gamelogdir
# unless gamelogdir is within logdir
# e.g serverfiles/log is not within log/: symlink created
# log/server is in log/: symlink not created
if [ -n "${gamelogdir}" ]; then
	if [ "${gamelogdir:0:${#logdir}}" != "${logdir}" ];then
		ln -nfsv "${gamelogdir}" "${logdir}/server"
	fi
fi

Specific games will need to be reviewed however to make sure that it still works.

The following servers need to be checked
twserver
rustserver
qlserver
all unreal servers
hwserver

@dgibbs64 commented on GitHub (May 15, 2017): My current solution required no extra vars ``` # Symlink to gamelogdir # unless gamelogdir is within logdir # e.g serverfiles/log is not within log/: symlink created # log/server is in log/: symlink not created if [ -n "${gamelogdir}" ]; then if [ "${gamelogdir:0:${#logdir}}" != "${logdir}" ];then ln -nfsv "${gamelogdir}" "${logdir}/server" fi fi ``` Specific games will need to be reviewed however to make sure that it still works. The following servers need to be checked twserver rustserver qlserver all unreal servers hwserver

kerem commented

2026-02-27 02:54:56 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Jun 20, 2017):

This issue was resolved in the latest release

@dgibbs64 commented on GitHub (Jun 20, 2017): This issue was resolved in the latest release

kerem commented

2026-02-27 02:54:56 +03:00

Author

Owner

@lock[bot] commented on GitHub (Jul 18, 2018):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Jul 18, 2018): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.