starred/LAN-Orangutan
1
0
Fork 0
mirror of https://github.com/291-Group/LAN-Orangutan.git synced 2026-04-27 10:25:59 +03:00
Code Issues Projects Releases 1 Packages Wiki Activity

[PR #4] [MERGED] Fix label case corruption when editing devices #3

New issue
Closed
opened 2026-03-13 13:04:21 +03:00 by kerem · 0 comments
kerem commented 2026-03-13 13:04:21 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/291-Group/LAN-Orangutan/pull/4
Author: @FileBay
Created: 12/31/2025
Status: ✅ Merged
Merged: 12/31/2025
Merged by: @FileBay

Base: main ← Head: claude/audit-code-bugs-NaPWC

📝 Commits (1)

  • cb8b723 Fix label case corruption when editing devices

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 web/assets/app.js (+1 -1)
📝 web/index.php (+2 -1)

📄 Description

The data-label attribute was lowercase for search filtering, but editDevice() used it to populate the edit form. This caused labels to silently become lowercase when users clicked edit and saved.

Added separate data-label-original attribute to preserve original case for the edit modal while keeping lowercase version for search.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/291-Group/LAN-Orangutan/pull/4 **Author:** [@FileBay](https://github.com/FileBay) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@FileBay](https://github.com/FileBay) **Base:** `main` ← **Head:** `claude/audit-code-bugs-NaPWC` --- ### 📝 Commits (1) - [`cb8b723`](https://github.com/291-Group/LAN-Orangutan/commit/cb8b72389b267d7890954b59b14be5b7b14fc022) Fix label case corruption when editing devices ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `web/assets/app.js` (+1 -1) 📝 `web/index.php` (+2 -1) </details> ### 📄 Description The data-label attribute was lowercase for search filtering, but editDevice() used it to populate the edit form. This caused labels to silently become lowercase when users clicked edit and saved. Added separate data-label-original attribute to preserve original case for the edit modal while keeping lowercase version for search. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-13 13:04:21 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v2.1.12
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LAN-Orangutan#3
No description provided.