[PR #5] [MERGED] Fix 2 bugs found in fifth review pass #4

Closed
opened 2026-03-13 13:04:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/291-Group/LAN-Orangutan/pull/5
Author: @FileBay
Created: 12/31/2025
Status: Merged
Merged: 12/31/2025
Merged by: @FileBay

Base: mainHead: claude/audit-code-bugs-NaPWC


📝 Commits (1)

  • 67480a6 Fix 2 bugs found in fifth review pass

📊 Changes

2 files changed (+12 additions, -1 deletions)

View changed files

📝 install.sh (+8 -1)
📝 web/api.php (+4 -0)

📄 Description

Critical:

  • Fix device update/group change API not working because IP was sent in POST body but read from URL. Now reads IP from body if not present in URL.

Low:

  • Fix install.sh not validating custom port input. User-provided port is now validated to be a number between 1-65535.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/291-Group/LAN-Orangutan/pull/5 **Author:** [@FileBay](https://github.com/FileBay) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@FileBay](https://github.com/FileBay) **Base:** `main` ← **Head:** `claude/audit-code-bugs-NaPWC` --- ### 📝 Commits (1) - [`67480a6`](https://github.com/291-Group/LAN-Orangutan/commit/67480a629d7b08c9f3a64a49ff259c7be6acf6a3) Fix 2 bugs found in fifth review pass ### 📊 Changes **2 files changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install.sh` (+8 -1) 📝 `web/api.php` (+4 -0) </details> ### 📄 Description Critical: - Fix device update/group change API not working because IP was sent in POST body but read from URL. Now reads IP from body if not present in URL. Low: - Fix install.sh not validating custom port input. User-provided port is now validated to be a number between 1-65535. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-13 13:04:21 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LAN-Orangutan#4
No description provided.